Implement magic bitboards for sliding piece move generation#1
Open
sbesselsen wants to merge 1 commit into
Open
Implement magic bitboards for sliding piece move generation#1sbesselsen wants to merge 1 commit into
sbesselsen wants to merge 1 commit into
Conversation
Replace the manual ray-casting implementation for rooks, bishops, and queens with O(1) magic bitboard lookups. This uses precomputed lookup tables indexed by a "magic" hash of the occupancy on relevant squares, similar to Stockfish's approach. Key changes: - Add magic.rs module with lazy-initialized lookup tables using OnceLock - Use proven magic numbers from Stockfish for both rooks and bishops - Simplify rooklike_moves_masks and bishoplike_moves_masks in board.rs - Handle board's inverted bit indexing at the interface All perft tests pass with correct results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the manual ray-casting implementation for rooks, bishops, and queens
with O(1) magic bitboard lookups. This uses precomputed lookup tables indexed
by a "magic" hash of the occupancy on relevant squares, similar to Stockfish's
approach.
Key changes:
All perft tests pass with correct results.