Speed up UniversalDataset batching for tabular data#175
Open
tippered1-debug wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a batched
__getitems__fast path forUniversalDatasetwhen no tokenizer is used.For tabular-only data, PyTorch
DataLoadercan request a whole batch of indices via__getitems__. The previous path fetched every row separately through__getitem__, then rebuilt the batch incollate_dict. The new path slices NumPy arrays once per batch and letscollate_dicthandle an already batched dictionary.The tokenizer/text path keeps the old row-wise behavior.
Changes
UniversalDataset.__getitems__for tabular-only batched fetching.collate_dictto accept bothlist[dict]and already batcheddict._dtypes_mapping.Benchmark
Synthetic benchmark, 200k rows:
tabular_balanced: 15.239x faster batch fetchingtabular_many_cat: 11.083x faster batch fetchingtabular_large_batch: 6.944x faster batch fetchingThis benchmark measures the
UniversalDataset/DataLoaderbatch fetching path, not full model training time.Tests
pytest tests/unit/test_text/test_universal_dataset.py -q