fix(pdo-fbird): make split package self-contained#563
Merged
Conversation
The pdo-fbird PIE package (satwareAG/pdo-fbird) failed to build because its source files used #include "../firebird_utils.h" etc., referencing parent headers that don't exist in the split repo. Fix: - Copy 5 shared headers + VERSION.txt into pdo_fbird/ directory: firebird_utils.h, php_firebird.h, php_fbird_includes.h, fbird_classes.h, fbird_service_types.h - Change all #include "../xxx.h" to #include "xxx.h" (local) - Rewrite config.m4: remove PHP_ADD_INCLUDE([$srcdir/..]) and $srcdir/../VERSION.txt references Verified: - Split build: phpize + configure + make in isolated /tmp/pdo-fbird-split/ - In-tree build: main Makefile builds both firebird.so and pdo_fbird.so - No ../ references remain in any pdo_fbird/ source or config file The split-stubs.yml workflow automatically includes all files in pdo_fbird/ via subtree split, so no workflow changes needed. Fixes: pie install satwareag/pdo-fbird build failure (#485)
satwareAG-ironMike
added a commit
that referenced
this pull request
Jul 21, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pie install satwareag/pdo-fbirdfails with:The pdo-fbird PIE package (split to
satwareAG/pdo-fbirdrepo) references parent headers (../firebird_utils.h,../php_firebird.h, etc.) that don't exist in the split repo.Fix
Copy 5 shared headers + VERSION.txt into
pdo_fbird/directory so the split package is self-contained:firebird_utils.hphp_fbird_includes.hphp_firebird.hfbird_classes.hfbird_service_types.hVERSION.txtThen changed all
#include "../xxx.h"to#include "xxx.h"(local references).Also rewrote
config.m4:PHP_ADD_INCLUDE([$srcdir/..])$srcdir/../VERSION.txtto$srcdir/VERSION.txtVerification
Split build (simulated PIE install)
In-tree build (main repo)
No
../references remainSplit workflow
No changes needed to
split-stubs.yml. Thedanharrin/monorepo-split-github-actiondoes a subtree split ofpdo_fbird/, which now includes all the shared headers.After merge
v13.0.3(version bump)split-stubs.ymlpushes the fixedpdo_fbird/tosatwareAG/pdo-fbirdpie install satwareag/pdo-fbirdwill workRelates: #485