fix(test_from_matrix): assume max precision - #36
Open
MarcoMiretti wants to merge 1 commit into
Open
Conversation
Author
|
Hmm. i guess something funny is happening with precision in python 3.4 🤔 |
MarcoMiretti
force-pushed
the
fix-test-from-matrix
branch
3 times, most recently
from
September 9, 2020 14:31
a66d248 to
8854964
Compare
When converting to matrix back and forth, coordinates appear to be rounded to a precision of 1e-8. This causes sporadic failures in said test. Routd the arr coordiantes to DEFAULT_TOLERANCE.
MarcoMiretti
force-pushed
the
fix-test-from-matrix
branch
from
September 9, 2020 14:48
8854964 to
b911ed2
Compare
Author
Fixed it changing the approach. Instead of assuming that the values are rounded, just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting to matrix back and forth, coordinates appear to be
rounded to a precision of 1e-8. This causes sporadic failures in said
test.
For this test it should be assumed that the coordinates of
arrcan bedescribed with said precision.
Solves issue #30
Example of what i think is causing the problem: