Skip to content

Be able to go to home page after games end.#92

Open
haddeeann wants to merge 3 commits into
sarmadhamdani02:masterfrom
haddeeann:home-btn-gitignore
Open

Be able to go to home page after games end.#92
haddeeann wants to merge 3 commits into
sarmadhamdani02:masterfrom
haddeeann:home-btn-gitignore

Conversation

@haddeeann

Copy link
Copy Markdown

I noticed that after playing the game there was no way to go 'home'. This seemed like a feature that I would want as a player. I changed the classes around a little bit for the end game buttons so the JavaScript uses something different to end the game vs the CSS class.

That way the CSS will be the same for 'home' button and 'replay' buttons. But the JavaScript will be different.

I could be wrong, but I've always just seen the git ignore file without a .txt extension.

… all the games. Renamed the classes so that the JavaScript wouldn't affect the home button, so styles and JavaScript are different.
@netlify

netlify Bot commented Dec 24, 2023

Copy link
Copy Markdown

Deploy Preview for webgames02 ready!

Name Link
🔨 Latest commit 69a3029
🔍 Latest deploy log https://app.netlify.com/sites/webgames02/deploys/65cac8051b25530008796dc5
😎 Deploy Preview https://deploy-preview-92--webgames02.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarmadhamdani02

Copy link
Copy Markdown
Owner

Hi @haddeeann, Thank you so much for the pull request 😊
Could you please clarify which game are you talking about? Or you are talking about all the games? 🤔

@haddeeann

Copy link
Copy Markdown
Author

All the games. I added a 'go home' button to all of them. I like the idea of the project and just wanted some way to contribute.

@sarmadhamdani02

Copy link
Copy Markdown
Owner

hi @haddeeann 👋
I really liked this idea and also reviewed the PR, it is great👏

But here is one thing to consider,
Once we click on the game icon on the home page, the game opens in another tab. The reason is simple to make it easy for the user to return to the home page. Now, if we add a home button, this button will bring us to the home screen on the same tab, in this way if the user keeps playing the games once by one it will keep opening the tabs and waste the device's memory. One thing we can do is instead of opening games on another tab, open them on the same tab.
What do you think about this idea?

@haddeeann

haddeeann commented Feb 6, 2024 via email

Copy link
Copy Markdown
Author

…n the same window we don't have to open in a new tab
@haddeeann

Copy link
Copy Markdown
Author

Lols, sorry it took me so long to update the PR :) I'm very happy to be able to contribute!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants