Skip to content

Change text from Dark mode to Light mode by clicking#84

Open
ChaviSchatz wants to merge 3 commits into
sarmadhamdani02:masterfrom
ChaviSchatz:master
Open

Change text from Dark mode to Light mode by clicking#84
ChaviSchatz wants to merge 3 commits into
sarmadhamdani02:masterfrom
ChaviSchatz:master

Conversation

@ChaviSchatz

Copy link
Copy Markdown

Hi!
In the meantime, I changed the Dark Mode button - which will change to Light Mode when pressed.

@sarmadhamdani02

Copy link
Copy Markdown
Owner

Hi @ChaviSchatz 👋
Thanks for the PR.

If you are talking about the icon below,
image

Then, it can be a good idea. But I think in this way we should increase the size of the icon a bit in order to make it a bit more appealing. 🤔

@ChaviSchatz

Copy link
Copy Markdown
Author

Sorry I didn't consider mobile mode but only computer mode. I will work on it
Thanks!

@sarmadhamdani02

Copy link
Copy Markdown
Owner

I apologize, but I'm having trouble understanding the purpose of this PR. Could you please explain?

@ChaviSchatz

Copy link
Copy Markdown
Author

Yes, sorry I wasn't clear.
What I did is that when you click on Dark Mode, the screen goes dark.
So instead of it now being written Dark Mode to make it bright I changed it to Light Mode which will become bright.
I did it. Interested in it?

@ChaviSchatz

Copy link
Copy Markdown
Author

Attached photos. You will understand more what I meant.

Dark Mode
Light Mode

@sarmadhamdani02

sarmadhamdani02 commented Oct 2, 2023

Copy link
Copy Markdown
Owner

Ok, thank you so much for the clarification. 😊
I will soon review the PR and will let you know if there is any change required.

@sarmadhamdani02

Copy link
Copy Markdown
Owner

Hi there 👋
Just saw the latest changes made. I don't really think that changing that background and tic-tac-toe's thumbnail is really necessary. 🤔
What do you say?

@ChaviSchatz

Copy link
Copy Markdown
Author

I thought it might add to the visibility of the page.
But of course not necessary...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants