Skip to content

Updated brick/math dependency to 0.18.0#14

Merged
vadymtsots merged 2 commits into
sapientpro:masterfrom
mic2100:master
Jun 18, 2026
Merged

Updated brick/math dependency to 0.18.0#14
vadymtsots merged 2 commits into
sapientpro:masterfrom
mic2100:master

Conversation

@mic2100

@mic2100 mic2100 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Also fixed many deprecation issues throughout the repo

This will also work with any math/brick version from 0.14.8 and above

Also fixed many deprecation issues throughout the repo
@vadymtsots

Copy link
Copy Markdown
Collaborator

@mic2100 thanks for the PR, these are useful changes!
I have only one concern about the usage of @ before file_get_contents and imagecreatefromstring. It may make the debugging and diagnostics harder for the consumers of the package, so I would leave it as it is and let the consumers handle these warnings

@mic2100

mic2100 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

I am running on 8.5 and keep getting these warnings and deprecation issues

image

And when I upgrade to math/brick 0.18.0 I get the same, so it was an attempt to prevent them from showing. I have changed the way it ignores the errors in the tests.

image

@vadymtsots vadymtsots merged commit adc97a8 into sapientpro:master Jun 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants