Skip to content

WIP: feat: update eslint/prettier configs#189

Open
drmikecrowe wants to merge 4 commits into
sapegin:masterfrom
drmikecrowe:master
Open

WIP: feat: update eslint/prettier configs#189
drmikecrowe wants to merge 4 commits into
sapegin:masterfrom
drmikecrowe:master

Conversation

@drmikecrowe

Copy link
Copy Markdown

@sapegin -- this is NOT ready for release yet, but wanted to show you my current code.

The latest eslint-config-prettier simplifies things considerably, so I updated my eslint task to migrate to the latest config.

Additionally, I added support for yarn and vue (both require some tweaks to the base code).

LMK if you want me to pursue this -- I'll have to fix the tests and see what else needs to be done

@sapegin

sapegin commented Aug 3, 2021

Copy link
Copy Markdown
Owner

Looks good so far!

There are two issues with the current approach in general (not with this pull request, these are more of thinking loud):

  1. Messy code with lots of conditions that's hard to read and maintain.
  2. No way to disable all the magic, which could be necessary when you use your own preset that may already include the plugins.

@everdimension

Copy link
Copy Markdown

Hello @sapegin!

Is this still being worked on?

As of prettier v8 https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21, current mrm prettier setup creates a config that produces an error:

Error: Cannot read config file: `//node_modules/eslint-config-prettier/@typescript-eslint.js
Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21

Will this PR be merged eventually or should I help create a new one which just solves the above issue?

@sapegin

sapegin commented Jul 4, 2023

Copy link
Copy Markdown
Owner

@everdimension Please open a new pull request, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants