User-configurable default preset#186
Open
ext wants to merge 2 commits into
Open
Conversation
sapegin
requested changes
Jul 21, 2021
sapegin
left a comment
sapegin
left a comment
Owner
There was a problem hiding this comment.
Thanks! This is a good feature! I've left a couple of minor comments.
ext
force-pushed
the
feature/default-preset
branch
2 times, most recently
from
3971938 to
40b32b0
Compare
Codecov Report
|
sapegin
approved these changes
Sep 8, 2021
sapegin
left a comment
sapegin
left a comment
Owner
There was a problem hiding this comment.
This looks good now, thanks! I have two minor comments. For the future, we should get rid of any mentions of the default preset in the code since there's no such thing anymore.
|
|
||
| ## Default preset | ||
|
|
||
| The default preset is `mrm-preset-default`, you can set a custom default preset in `.mrm/config.json`: |
Owner
There was a problem hiding this comment.
This is no longer true, mrm-preset-default is deprecated and tasks are autoinstalled by default.
Collaborator
Author
There was a problem hiding this comment.
I've updated the documentation, let me know if you want additional changes
ext
force-pushed
the
feature/default-preset
branch
from
d214805 to
c5d6f04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to specify their own custom default preset.
In my opinion the strength of
mrmis not the default tasks but the ability to create your own presets and tasks to setup applications and repositories. The default tasks interferes, uses the wrong configuration and is in general incomplete for my purposes. The major issue is that with an organization or company you want more control over the configuration.By setting my own default preset it is easier to ensure that
npx mrm eslintwill setup eslint my way. Actively entering--preset @mycompany/unicornis tedious when you want to run it across multiple repositories or when you want to run multiple tasks sequentially (i.e. task, commit, task, commit).I do recognize that it might be a bit of documentation issue since
npx mrm mytaskmight to different things on different machines but I hope the changes to output makes it more clear: