Skip to content

libvirt: ignore InstanceNotFound for BFV cold migration #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
PaulPickhardt wants to merge 1 commit into
base: stable/2023.2-m3
Choose a base branch
from
Draft

libvirt: ignore InstanceNotFound for BFV cold migration #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion nova/virt/libvirt/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11795,7 +11795,21 @@ def migrate_disk_and_power_off(self, context, instance, migration,
connection_info = vol['connection_info']
self._disconnect_volume(context, connection_info, instance)

disk_info = self._get_instance_disk_info(instance, block_device_info)
# For boot-from-volume instances the domain may already be gone from
# libvirt (e.g. on a migration retry) but there are no local disks to
# copy, so InstanceNotFound is safe to ignore here.
if booted_from_volume:
try:
disk_info = self._get_instance_disk_info(instance,
block_device_info)
except exception.InstanceNotFound:
LOG.debug('Libvirt domain not found for boot-from-volume '
'instance during migration, no local disks to '
'copy.', instance=instance)
disk_info = []
else:
disk_info = self._get_instance_disk_info(instance,
block_device_info)

try:
# If cleanup failed in previous resize attempts we try to remedy
Expand Down