Live-Migrate With Config-Drive CD-Rom#339
Merged
Merged
Conversation
Member
Author
|
I'll split out the change with moving the serializer out to oslo.vmware |
fwiesel
force-pushed
the
resize_with_cdrom
branch
from
1ab56be to
39ab819
Compare
Member
Author
|
Now based on #340 |
fwiesel
force-pushed
the
resize_with_cdrom
branch
from
39ab819 to
f909b9f
Compare
Most code related to vms is in vmops, not in the driver So we move this code there too Change-Id: I1b801c8f12b377dd74a31ef646216c564631fe7f
This requires a change to oslo.vmware to accept a string instead of only a cookiejar. Depends-On: Ia9f16758c388afe0fe05034162f516844ebc6b2b Change-Id: I34a0c275ed48489954e50eb15f8ea11c4f6b1aa6
fwiesel
force-pushed
the
resize_with_cdrom
branch
2 times, most recently
from
1f8a308 to
00ad162
Compare
joker-at-work
left a comment
joker-at-work
left a comment
There was a problem hiding this comment.
I can't say why, but this code is hard to follow for me and it looks extremely hacky, too :(
fwiesel
force-pushed
the
resize_with_cdrom
branch
from
00ad162 to
0155dfd
Compare
While we cannot live-migrate CD-Roms directly between vcenters, we can copy the data and detach/reattach the device manually. Change-Id: I88b4903f745e1bcfe957ddc07c6e9c040820ed6b
fwiesel
force-pushed
the
resize_with_cdrom
branch
from
0155dfd to
f3a5d33
Compare
joker-at-work
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes implement the following for live-migrating vms with config-drive cdroms:
On failure, the cdrom is re-attached again
This depends on sapcc/oslo.vmware#23