[customdns] removing customdns configuration via neutron config file#110
Open
mutax wants to merge 1 commit into
Open
[customdns] removing customdns configuration via neutron config file#110mutax wants to merge 1 commit into
mutax wants to merge 1 commit into
Conversation
mutax
force-pushed
the
i583594/customdns-cleanup
branch
5 times, most recently
from
12267dc to
70d7a4f
Compare
mutax
changed the title
mutax
force-pushed
the
i583594/customdns-cleanup
branch
from
70d7a4f to
bd313a8
Compare
The customdns configuration is now done using a yaml config file pointed to in the neutron config file. This commit removes the now unused options from the configuration, removes the obsolete code and the tests and cleans up the code. With this change the yaml configuration file is now mandatory when the customdns feature is enabled. We also renamed some of the tests to better describe their purpose and renamed the "doubled" tests for the functionality back to the original names by removing the _yaml postfix. Additional tests ensure the configuration file is required when the customdns feature is enabled and exceptions are handled accordingly.
mutax
force-pushed
the
i583594/customdns-cleanup
branch
from
bd313a8 to
24068ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The customdns configuration is now done using a yaml config file pointed to in the neutron config file.
This commit removes the now unused options from the configuration, removes the obsolete code and the tests and cleans up the code.
With this change the yaml configuration file is now mandatory when the customdns feature is enabled.
We also renamed some of the tests to better describe their purpose and renamed the "doubled" tests for the functionality back to the original names by removing the _yaml postfix.
Additional tests ensure the configuration file is required when the customdns feature is enabled and exceptions are handled accordingly.