Emit Kubernetes events on pods during eviction#388
Open
databus23 wants to merge 1 commit into
Open
Conversation
Record a Normal event on each Pod as it is evicted, deleted, or force-deleted during a node drain. Events are visible via `kubectl describe pod` and help operators understand why a pod was terminated during maintenance. The event recorder is threaded through DrainParameters (optional, nil-safe) and passed from the main reconciler, ESX controller, and kubernikus controller.
databus23
requested review from
Nuckal777,
SchwarzM,
defo89,
goerangudat and
videlov
as code owners
Merging this branch changes the coverage (2 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
defo89
reviewed
May 25, 2026
| GracePeriodSeconds *int64 | ||
| // optional recorder to emit events on evicted pods | ||
| Recorder events.EventRecorder | ||
| Node *corev1.Node |
Member
There was a problem hiding this comment.
Nit- do we need to pass the Node *corev1.Node via DrainParameters? Seems it's already being received in EnsureDrain and deleteNode calls directly.
ref
https://github.com/sapcc/maintenance-controller/blob/master/plugin/impl/eviction.go#L83
https://github.com/sapcc/maintenance-controller/blob/master/esx/runnable.go#L167
https://github.com/sapcc/maintenance-controller/blob/master/kubernikus/node_controller.go#L109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalevent on each Pod when it is evicted, deleted, or force-deleted during a node drainkubectl describe podand show the Node as the related objectDrainParametersis optional (nil = no events), so existing callers and tests work without changesTest plan
go build ./...compiles cleanlycommon,state,plugin,plugin/impl)gmake build/cover.outpasses (ESX suite is flaky on timing but passes on retry)kubectl get events --field-selector regarding.name=<pod>shows eviction event