Use events.k8s.io API group instead of legacy core/v1 Events#386
Open
databus23 wants to merge 1 commit into
Open
Use events.k8s.io API group instead of legacy core/v1 Events#386databus23 wants to merge 1 commit into
databus23 wants to merge 1 commit into
Conversation
The custom event broadcaster (event/event.go) only affected the deprecated record.EventBroadcaster path in controller-runtime, while mgr.GetEventRecorder() uses the newer events.k8s.io API exclusively. This caused RBAC errors in production since the ClusterRole only granted access to core/v1 events. Remove the dead custom broadcaster, update RBAC markers to events.k8s.io, and update test assertions to use eventsv1.EventList.
databus23
requested review from
Nuckal777,
SchwarzM,
defo89,
goerangudat and
videlov
as code owners
Merging this branch changes the coverage (2 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
defo89
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event.EventBroadcaster— it only affected the deprecatedrecord.EventBroadcasterpath in controller-runtime, whilemgr.GetEventRecorder()uses the newerevents.k8s.ioAPI exclusivelygroups=coretogroups=events.k8s.iofor eventseventsentry from leader election role (client-go v0.36.0 leader election uses leases only)eventsv1.EventListandregarding.namefield selectorFixes production error:
Test plan
gmake build/cover.out)gmake build-all)config/rbac/role.yamlcorrectly showsevents.k8s.iogroupkubectl describe nodeshows events