fix(etcd): mount Swift credentials as files for etcdbrctl#1074
Merged
Conversation
etcdbrctl v0.28+ unconditionally checks Swift credential file mtime before every snapshot; without OPENSTACK_APPLICATION_CREDENTIALS set, it refuses to upload. Mount the etcd Secret as files at /var/etcd/swift-creds with upstream-expected names (tenantName, authURL, ...).
v1.62.2 was built with Go 1.23 and rejects Go 1.25 targets.
Was the chart fullname since f27b672. v0.25.1 only read POD_NAMESPACE for lease heartbeats (disabled here), so the wrong value was harmless. v0.41.2 reads it to look up the etcd workload and fails when it's not a real namespace.
ed5a5a1 added a `required` for projectName in the etcd Swift secret; test-charts rendering had no fixture and broke.
|
Chart bump not needed here? |
databus23
requested changes
May 28, 2026
The etcd chart marks openstack-project-name as required, so existing klusters whose Secret lacks it would fail Helm render on operator rollout. Migration 22 fetches it from Keystone; NoCloud klusters and Secrets that already have it are skipped.
Contributor
Author
|
@jknipper @databus23 , could you please look at this PR? |
MaximShepelev
approved these changes
Jun 2, 2026
databus23
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
etcdbrctl v0.28+ unconditionally checks Swift credential file mtime before every snapshot; without OPENSTACK_APPLICATION_CREDENTIALS set, it refuses to upload. Mount the etcd Secret as files at /var/etcd/swift-creds with upstream-expected names (tenantName, authURL, ...).