Adopt Detached VMware Root VMDKs as FCD Volumes#349
Open
anokfireball wants to merge 3 commits into
Open
Conversation
anokfireball
force-pushed
the
manage-ephemeral-to-fcd
branch
5 times, most recently
from
db8a760 to
b535908
Compare
Let drivers signal safe pre-relocate failures by setting volume status to 'error' so the manage_existing flow preserves that state on rollback instead of always reverting to 'error_managing'. Add recovery logging in ManageExistingTask when the DB update cannot be persisted after a driver has already adopted the backend object. Change-Id: I4d060160561fd8df4e1869194a14934edf40f060
anokfireball
force-pushed
the
manage-ephemeral-to-fcd
branch
4 times, most recently
from
69f015b to
e3cad05
Compare
Add manage_existing and manage_existing_get_size overrides to VMwareVStorageObjectDriver. Parses the '[ds] path.vmdk' source-name ref, validates caller-provided size_gb, registers the VMDK as a First Class Disk via RegisterDisk, and relocates it to the target datastore when source and target moref differ. All pre-relocate failures mark the volume as 'error' (safe for Nova abort); relocate and post-relocate failures leave status at the flow-owned 'error_managing'. No error path calls delete_fcd or unregister_disk. Change-Id: Ic7faba0b8aefaff1472a5ff0d380547c856f1a63
anokfireball
force-pushed
the
manage-ephemeral-to-fcd
branch
6 times, most recently
from
515e987 to
b4b7a8f
Compare
Problem: The volume_extension:volume_manage policy defaults to rule:admin_api, so only admin users can call the manage_existing API. When another service (e.g. Nova) calls manage_existing on behalf of a user, the request carries the user's token as primary (for correct volume ownership and quota attribution) plus the service's token as secondary. The non-admin user token is rejected by the policy. Solution: Before enforcing the admin-only policy, check whether the request carries a valid service token using the existing is_service_request() helper (checks ctxt.service_roles against the configured service_token_roles). If the request comes from a trusted service, skip the policy check. This mirrors the pattern already used in attachment_deletion_allowed() for service-initiated detach operations. The admin path and the non-admin-without-service-token path remain unchanged. Change-Id: I88b07712f399dae7654d238605f6f410a1b5a9ba
anokfireball
force-pushed
the
manage-ephemeral-to-fcd
branch
from
b4b7a8f to
9e40b70
Compare
|
KVM based volumes are owned by the Netapp driver, not the vmware fcd driver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to move image-backed OpenStack servers from VMware to KVM. Those servers boot from Nova-owned VMDKs on VMware ephemeral datastores. KVM cannot use those disks directly. Before the resize can continue on KVM, the root VMDK needs to become a Cinder-managed disk on an NFS-backed datastore. We are using FCD as an intermediate representation that can be attached to both VMware and KVM hosts (via #288). This PR adds the Cinder side of that conversion.
The FCD driver now has its own
manage_existingimplementation instead of inheriting the VMDK driver's shadow-VM path. It accepts a detached VMDK reference in[datastore] path.vmdkform. If the ref carries an optionalsource-id(the vSphere FCD id, passed by Nova whenVirtualDisk.vDiskIdis present before detach), the driver validates the FCD backing path matchessource-nameand renames it; otherwise it callsRegisterDisk. In both cases the FCD is then relocated if the selected Cinder datastore differs from the source. The returnedprovider_locationpoints at the final FCD location, so the existing FCD attach paths keep working.If
RegisterDiskreports the disk is already registered and nosource-idwas provided, the driver fails clearly withManageExistingInvalidReferenceand tells the caller to passsource-id.The shared
manage_existingflow preserves the volume status set by the driver on rollback. Pre-relocate failures mark the volume aserrorso Nova can abort and reattach the original VMDK. Failures during or after relocate end up inerror_managing, where an operator needs to recover the managed FCD.The manage API policy (
volume_extension:volume_manage) accepts service-token callers via a customis_service_request:Trueoslo.policy check registered incinder/policies/base.py. This allows Nova to callmanage_existingon behalf of a user without requiring the user to have the admin role. Deployments that override this policy inpolicy.yamlmust addor is_service_request:Trueto their override.The storage-side safety rule is simple: never delete the disk while adopting it. The new path does not call
delete_fcdor unregister anything on failure. It logs source path, FCD id when known, target datastore, and failure reason.Nova will call this later from the image-backed VMware-to-KVM resize pre-step. Until then it is inert; nothing calls this FCD manage path unless a caller explicitly passes a detached VMDK reference to the manage API.