Skip to content

Fix link hint for ProLiant DL345 Gen11v2#158

Closed
stwilkes wants to merge 1 commit into
mainfrom
fix-proliant-dl345-interface
Closed

Fix link hint for ProLiant DL345 Gen11v2#158
stwilkes wants to merge 1 commit into
mainfrom
fix-proliant-dl345-interface

Conversation

@stwilkes

Copy link
Copy Markdown
Contributor

Update interface regex to include new interfaces like: ens3f0np0 and ens3f1np1

Update interface regex to include new interfaces like:
ens3f0np0
ens3f1np1
@github-actions

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/argora/internal/controller 84.69% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/argora/internal/controller/metal3_controller.go 74.70% (ø) 166 124 42

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@goerangudat goerangudat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adic9000 adic9000 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@defo89 defo89 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stwilkes Please rebase on main — a recently merged PR fixed lint/CI issues that conflict with this branch. A rebase should resolve the failing checks.

@stwilkes

Copy link
Copy Markdown
Contributor Author

New PR created: #165

@stwilkes stwilkes closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants