fix: empty endpoint path patterns crash on startup (SRCFG00040) - #15
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14. The built-in String converter treats an empty config value as null, which fails config mapping validation at startup — so the README's "set to an empty string to disable" crash-loops the app, and since the keys are defined in
application.propertiesthey cannot be removed via env vars either.This keeps empty values alive through mapping with a pass-through converter and filters them out of
endpointPathPatterns(), so empty-means-disabled works as documented (the frontend already hides absent patterns). Includes a regression test that reproduces the startup crash on the previous code.