feat(shopify-assets)!: migrate react-photo-album to v3 catalog - #1822
Draft
stipsan wants to merge 1 commit into
Draft
feat(shopify-assets)!: migrate react-photo-album to v3 catalog#1822stipsan wants to merge 1 commit into
stipsan wants to merge 1 commit into
Conversation
Upgrade the shared react-photo-album catalog to ^3.6.1 and migrate sanity-plugin-shopify-assets to the v3 RowsPhotoAlbum + scroll API (matching asset-source-unsplash), so it can use catalog: and drop the v2-only react-infinite-scroll-component/rxjs search path.
🦋 Changeset detectedLatest commit: 59c6e47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
✅ E2E Tests🟢 24 passed • view full report • view run Studio: https://plugins-e2e-test-studio-pdiyrwgh6.sanity.dev Datasets: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1798 (Renovate-only bump without the v2→v3 API migration).
Summary
react-photo-albumcatalog^3.6.0→^3.6.1sanity-plugin-shopify-assetsto the v3 API (major), followingsanity-plugin-asset-source-unsplash:PhotoAlbum layout="rows"→RowsPhotoAlbum+react-photo-album/rows.cssreact-infinite-scroll-component→react-photo-album/scrollrender.extrasoverlayscomponentsProps.containerProps→componentsProps.containerfetchAssetsdatastore (drops rxjs subjects for search)"react-photo-album": "catalog:"sanity-plugin-asset-source-unsplash(catalog consumer)Test plan
pnpm formatpnpm lintpnpm knipsanity-plugin-shopify-assets+sanity-plugin-asset-source-unsplashvitestforsanity-plugin-shopify-assets