feat(skill): install bundled agent skill#60
Conversation
Signed-off-by: samzong <samzong.lu@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa69d20ebb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let flags = kitup::parse_install_flags(kitup::InstallFlagValues { | ||
| scope, | ||
| scope_set: false, | ||
| agents, |
There was a problem hiding this comment.
Honor explicit --scope before prompting
When recall skill install --scope project is used, this still passes scope_set: false, so kitup is told the user did not provide a scope even though scope is Some("project"). Because the workflow is also configured with default_scope: User and prompt_scope: true, explicit non-default scope selection can be re-prompted or treated as policy/default-selected rather than user-selected; set this from whether the CLI scope argument was present before moving scope into the flag parser.
Useful? React with 👍 / 👎.
What's changed?
kitup0.1.1 as the bundled skill installer dependency.recall skill installwith--scope,--agent,--dry-run, and--yessupport.Why
Verification
cargo search kitup --limit 1cargo checkcargo run -- skill install --scope user --agent codex --dry-run --yeswith a temporaryHOMEcargo test cli::tests::skill_install_accepts_kitup_flagscargo test cli::testsmake check/pre-ship --committed(MUST-FIX 0, deferred 0)