Skip to content

feat(skill): install bundled agent skill#60

Merged
samzong merged 1 commit into
mainfrom
feat/skill-install
Jun 29, 2026
Merged

feat(skill): install bundled agent skill#60
samzong merged 1 commit into
mainfrom
feat/skill-install

Conversation

@samzong

@samzong samzong commented Jun 29, 2026

Copy link
Copy Markdown
Owner

What's changed?

  • Add kitup 0.1.1 as the bundled skill installer dependency.
  • Add recall skill install with --scope, --agent, --dry-run, and --yes support.
  • Embed the existing Recall skill bundle and cover the new CLI parsing path.

Why

  • Let Recall install its bundled Agent Skill through kitup's conflict-safe ownership workflow.

Verification

  • cargo search kitup --limit 1
  • cargo check
  • cargo run -- skill install --scope user --agent codex --dry-run --yes with a temporary HOME
  • cargo test cli::tests::skill_install_accepts_kitup_flags
  • cargo test cli::tests
  • make check
  • /pre-ship --committed (MUST-FIX 0, deferred 0)

Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong samzong merged commit da4dea8 into main Jun 29, 2026
1 check passed
@samzong samzong deleted the feat/skill-install branch June 29, 2026 18:27

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa69d20ebb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/cli.rs
Comment on lines +202 to +205
let flags = kitup::parse_install_flags(kitup::InstallFlagValues {
scope,
scope_set: false,
agents,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Honor explicit --scope before prompting

When recall skill install --scope project is used, this still passes scope_set: false, so kitup is told the user did not provide a scope even though scope is Some("project"). Because the workflow is also configured with default_scope: User and prompt_scope: true, explicit non-default scope selection can be re-prompted or treated as policy/default-selected rather than user-selected; set this from whether the CLI scope argument was present before moving scope into the flag parser.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant