the task #4 from HW #4 was completed - #4
Open
Dmitriy-Klv wants to merge 1 commit into
Open
Conversation
samodurOFF
reviewed
Apr 29, 2026
samodurOFF
left a comment
Owner
There was a problem hiding this comment.
Отличная работа. Можно мержить
Comment on lines
+68
to
+70
| all_categories = session.query(Category).all() | ||
|
|
||
| for category in all_categories: |
Owner
There was a problem hiding this comment.
У вас выходит проблема N+1. Потому что вы извлекаете связанные объекты множеством запросов в цикле. Лучше сделать 1 большой запрос
Suggested change
| all_categories = session.query(Category).all() | |
| for category in all_categories: | |
| data = session.query(Category, Product).join(Product).all() | |
| for category, product in data: | |
| # дальше сами |
Либо тоже через join, но уже по конкретным полям и таблица с Product будет слева
Suggested change
| all_categories = session.query(Category).all() | |
| for category in all_categories: | |
| data = session.query(Category.name, Product.name, Product.price).join(Category).all() | |
| for category, product, price in data: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.