Skip to content

Internalize UIKit plume view#21

Merged
samlupton merged 1 commit into
samlupton:mainfrom
Will-thom:fix/internalize-uikit-view
May 26, 2026
Merged

Internalize UIKit plume view#21
samlupton merged 1 commit into
samlupton:mainfrom
Will-thom:fix/internalize-uikit-view

Conversation

@Will-thom
Copy link
Copy Markdown
Contributor

Summary

  • make PlumeUIView internal and move it under the Internal source tree
  • keep PlumeView public by exposing UIView from the UIViewRepresentable bridge
  • remove public UIKit usage documentation from the README

Tests

  • git diff --cached --check
  • swift test (not run: Swift toolchain is not installed in this Windows environment)

@samlupton samlupton self-requested a review May 26, 2026 23:15
Copy link
Copy Markdown
Owner

@samlupton samlupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the MR.

@samlupton
Copy link
Copy Markdown
Owner

Running pipelines then it will merge

@samlupton samlupton merged commit 9493792 into samlupton:main May 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants