test: add comprehensive coverage for Termii SDK#2
Closed
samdoghor wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the codebase, focusing on enhanced error handling, improved parameter validation, and the addition of comprehensive unit tests. It also includes minor dependency and version updates. The changes improve the reliability, maintainability, and test coverage of the project.
Error Handling Improvements:
ValueErrorexceptions with more descriptiveClientConfigErrorexceptions inTermiiClient, providing clearer guidance and actionable error messages when required configuration values are missing. [1] [2]Parameter Validation and Logic Enhancements:
send_messageandsend_bulk_messagemethods to ensure correct usage and clearer error messages, preventing misuse of WhatsApp and voice channels. [1] [2]PhoneNumber.is_valid_phone_numbermore robust.Testing and Test Infrastructure:
TermiiClientconfiguration, HTTP request handling, and phone number value object, significantly increasing test coverage and reliability. [1] [2] [3]testdependency group inpyproject.tomlfor easier test setup withpytest.Other Updates:
0.1.2intermii_py/__init__.py.RequestHandler.post_fileby using a context manager to ensure files are properly closed after upload.