Review: 671be8b

[github-actions]

Code Review

Automated review of the last commit on dev.

Review Output

The change from `--add-reviewer` to `--reviewer` is **correct**. `gh pr create` does not support `--add-reviewer` (that flag is for `gh pr edit`). The correct flag for `gh pr create` is `--reviewer`.

No bugs, security issues, performance regressions, or breaking changes. This fix is a net improvement.

---

Generated by OpenCode Review

[samarth-na]

can you review the last commits too that are in this pr?

[samarth-na]

/oc can you review the last commits too that are in this pr?

[opencode-agent]

Reviewing the 3 commits in the PR (44a884e, 3dc253e, 671be8b). The prior review only covered the --reviewer flag — here are findings on the rest.

Issues found

1. chat.md — stray Chinese characters (.config/opencode/agents/chat.md:67)

present the strongest case each side would make rather than裁判 your own view.

The 裁判 (Chinese for "referee/judge") is clearly a paste artifact. Almost certainly meant to be impose or render. This will look broken to any reader.

2. opencode.jsonc — fabricated model name (.config/opencode/opencode.jsonc:12)

"worker": { "model": "opencode/deepseek-v4-flash-free" }

There is no published DeepSeek "v4" model — the current line is v3.x. This ID will likely fail at runtime with an unknown-model error. Verify the actual model name before merging.

3. opencode.jsonc — unpinned MCP package (.config/opencode/opencode.jsonc:50)

"command": ["npx", "-y", "@z_ai/mcp-server@latest"]

@latest for a network-fetched binary is a reproducibility and supply-chain risk — the running binary can change between runs. Pin a version.

4. package-lock.json — orphan dep az (.config/opencode/package-lock.json:9)

"az": "^0.2.3"

Added to dependencies of the root package, but there is no package.json in .config/opencode/ declaring it. npm will likely warn/prune this, and the name az is generic enough to be a typosquat concern. Also, several platform packages got flipped from "optional": true to "extraneous": true — looks like a botched npm install rather than an intentional change.

5. change-tmux-pane.sh — script cannot actually switch panes (.config/fish/scripts/change-tmux-pane.sh:8-15)
The format string includes #{pane_index}, but then:

| cut -d "." -f 1

strips everything after the first ., dropping pane_index. So despite the name, the script only ever switches window, never pane. Either keep the pane index (use -t session:window.pane) or rename the script. Also tmux switch-client … 2>/dev/null || true silently swallows failures — at least warn.

6. Missing trailing newlines in change-tmux-pane.sh, chat.md, worker.md, AGENTS.md, opencode.yml. Minor, but the \ No newline at end of file markers show up in every diff.

Non-issues / nits

• .gitignore: adding .config/fish/conf.d/secrets.fish is correct. The removal of .config/git/a.out is presumably fine if you don't compile C there anymore.
• AGENTS.md rewrite: clearer structure, accurate gotchas (matches what I see in config.fish). Good change.
• --reviewer samarth-na in the workflow is correct (per prior review) but hardcoded — worth a comment that this must follow the GitHub username, not the display name.

Recommendation

Block on items 1, 2, 3, 4 (real correctness/security risks). 5 is a behavioral bug worth fixing before merge. The rest are cosmetic.

opencode session  |  github run

[github-actions]

Code Review

Automated review of the last commit on dev.

Review Output

### Bugs / Logic Errors

1. **`bkill.fish` / `bon.fish`**: Using `sed` with range patterns (`/pattern1/,/pattern2/`) on a JSONC file is fragile — any reformatting, comment insertion, or indentation change will silently break the toggle. A JSON-aware tool (e.g. `dasel`, `jq`, or a fish snippet using `python3 -c json`) would be far more robust.

2. **`cli.json` voice plugin**: Endpoint `http://127.0.0.1:1/v1` (port 1) is invalid — this will likely produce persistent connection errors or slow down opencode startup if the plugin attempts to connect eagerly.

3. **`.config/opencode/opencode.jsonc`**: `"shell": "/bin/bash"` removed — if opencode defaults to a different shell or none, this could silently change subprocess behavior.

4. **Typo in `.config/opencode/AGENTS.md`**: `"do not every run dev server"` → `"do not ever run dev server"` (instructional, not functional).

### Security

- `.gitignore` glob `service*` is slightly broader than `service.json` — unlikely to cause false positives in practice. No real concern.

---

Generated by OpenCode Review

[samarth-na]

/oc has there been multiple commits in this pr

[opencode-agent]

APIError: Insufficient balance. Manage your billing here: https://opencode.ai/workspace/wrk_01KRYC9M8H3G8TVMBWMV76HP44/billing

opencode session  |  github run

[opencode-agent]

APIError: Insufficient balance. Manage your billing here: https://opencode.ai/workspace/wrk_01KRYC9M8H3G8TVMBWMV76HP44/billing

opencode session  |  github run