Skip to content

PLASMA-5873: Свойство readOnly помечено как deprecated#2895

Merged
Yakutoc merged 4 commits into
devfrom
PLASMA-5873
Jun 22, 2026
Merged

PLASMA-5873: Свойство readOnly помечено как deprecated#2895
Yakutoc merged 4 commits into
devfrom
PLASMA-5873

Conversation

@Yakutoc

@Yakutoc Yakutoc commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Core

Checkbox, Radiobox

  • cвойство readOnly помечено как deprecated

What/why changed

Прямая ссылка на спецификацию WHATWG HTML Standard, где определён список типов, к которым применяется readonly:

https://html.spec.whatwg.org/multipage/input.html#attr-input-readonly

Там для каждого типа указано в таблице «Content attributes», применяется ли к нему readonly.

Для checkbox, radio, color, range, file и кнопок - не применяется.

Более явная формулировка - в разделе про список применимости атрибутов:

https://html.spec.whatwg.org/multipage/input.html#do-not-apply

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.380.1-canary.2895.27739720201.0
npm install @salutejs/plasma-b2c@1.622.1-canary.2895.27739720201.0
npm install @salutejs/plasma-giga@0.349.1-canary.2895.27739720201.0
npm install @salutejs/plasma-homeds@0.349.1-canary.2895.27739720201.0
npm install @salutejs/plasma-hope@1.376.1-canary.2895.27739720201.0
npm install @salutejs/plasma-new-hope@0.366.1-canary.2895.27739720201.0
npm install @salutejs/plasma-ui@1.352.1-canary.2895.27739720201.0
npm install @salutejs/plasma-web@1.624.1-canary.2895.27739720201.0
npm install @salutejs/sdds-bizcom@0.354.1-canary.2895.27739720201.0
npm install @salutejs/sdds-cs@0.358.1-canary.2895.27739720201.0
npm install @salutejs/sdds-dfa@0.352.1-canary.2895.27739720201.0
npm install @salutejs/sdds-finai@0.345.1-canary.2895.27739720201.0
npm install @salutejs/sdds-insol@0.349.1-canary.2895.27739720201.0
npm install @salutejs/sdds-netology@0.353.1-canary.2895.27739720201.0
npm install @salutejs/sdds-os@0.24.1-canary.2895.27739720201.0
npm install @salutejs/sdds-platform-ai@0.353.1-canary.2895.27739720201.0
npm install @salutejs/sdds-sbcom@0.354.1-canary.2895.27739720201.0
npm install @salutejs/sdds-scan@0.352.1-canary.2895.27739720201.0
npm install @salutejs/sdds-serv@0.353.1-canary.2895.27739720201.0
npm install @salutejs/sdds-api-tests@0.11.1-canary.2895.27739720201.0
npm install @salutejs/plasma-sb-utils@0.230.1-canary.2895.27739720201.0
# or 
yarn add @salutejs/plasma-asdk@0.380.1-canary.2895.27739720201.0
yarn add @salutejs/plasma-b2c@1.622.1-canary.2895.27739720201.0
yarn add @salutejs/plasma-giga@0.349.1-canary.2895.27739720201.0
yarn add @salutejs/plasma-homeds@0.349.1-canary.2895.27739720201.0
yarn add @salutejs/plasma-hope@1.376.1-canary.2895.27739720201.0
yarn add @salutejs/plasma-new-hope@0.366.1-canary.2895.27739720201.0
yarn add @salutejs/plasma-ui@1.352.1-canary.2895.27739720201.0
yarn add @salutejs/plasma-web@1.624.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-bizcom@0.354.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-cs@0.358.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-dfa@0.352.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-finai@0.345.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-insol@0.349.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-netology@0.353.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-os@0.24.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-platform-ai@0.353.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-sbcom@0.354.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-scan@0.352.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-serv@0.353.1-canary.2895.27739720201.0
yarn add @salutejs/sdds-api-tests@0.11.1-canary.2895.27739720201.0
yarn add @salutejs/plasma-sb-utils@0.230.1-canary.2895.27739720201.0

Summary by CodeRabbit

  • New Features

    • Added deprecated readOnly property to Checkbox component with HTML spec reference.
  • Documentation

    • Updated Checkbox and Radiobox documentation across all platforms to exclude readOnly from displayed properties table.
    • Improved component documentation formatting and layout consistency.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 29047cb9-c6ba-4da2-975e-df1825e0c9c9

📥 Commits

Reviewing files that changed from the base of the PR and between 79a8a40 and 859319a.

📒 Files selected for processing (29)
  • packages/plasma-new-hope/src/components/Checkbox/Checkbox.template-doc.mdx
  • packages/plasma-new-hope/src/components/Checkbox/Checkbox.types.ts
  • packages/plasma-new-hope/src/components/Radiobox/Radiobox.template-doc.mdx
  • website/plasma-b2c-docs/docs/components/Checkbox.mdx
  • website/plasma-b2c-docs/docs/components/Radiobox.mdx
  • website/plasma-giga-docs/docs/components/Checkbox.mdx
  • website/plasma-giga-docs/docs/components/Radiobox.mdx
  • website/plasma-homeds-docs/docs/components/Checkbox.mdx
  • website/plasma-homeds-docs/docs/components/Radiobox.mdx
  • website/plasma-web-docs/docs/components/Checkbox.mdx
  • website/plasma-web-docs/docs/components/Radiobox.mdx
  • website/sdds-bizcom-docs/docs/components/Checkbox.mdx
  • website/sdds-bizcom-docs/docs/components/Radiobox.mdx
  • website/sdds-cs-docs/docs/components/Checkbox.mdx
  • website/sdds-cs-docs/docs/components/Radiobox.mdx
  • website/sdds-finai-docs/docs/components/Checkbox.mdx
  • website/sdds-finai-docs/docs/components/Radiobox.mdx
  • website/sdds-insol-docs/docs/components/Checkbox.mdx
  • website/sdds-insol-docs/docs/components/Radiobox.mdx
  • website/sdds-netology-docs/docs/components/Checkbox.mdx
  • website/sdds-netology-docs/docs/components/Radiobox.mdx
  • website/sdds-platform-ai-docs/docs/components/Checkbox.mdx
  • website/sdds-platform-ai-docs/docs/components/Radiobox.mdx
  • website/sdds-sbcom-docs/docs/components/Checkbox.mdx
  • website/sdds-sbcom-docs/docs/components/Radiobox.mdx
  • website/sdds-scan-docs/docs/components/Checkbox.mdx
  • website/sdds-scan-docs/docs/components/Radiobox.mdx
  • website/sdds-serv-docs/docs/components/Checkbox.mdx
  • website/sdds-serv-docs/docs/components/Radiobox.mdx

📝 Walkthrough

Walkthrough

BaseboxProps in Checkbox.types.ts gains new styling and behavioral props and a deprecated readOnly field; CheckboxProps now omits readOnly from InputHTMLAttributes. Matching PropsTable exclude configurations are updated in template docs and across all 13 website documentation sites for both Checkbox and Radiobox, with minor JSX and whitespace reformatting in several usage sections.

Changes

Checkbox/Radiobox readOnly deprecation and docs propagation

Layer / File(s) Summary
Checkbox type contract updates
packages/plasma-new-hope/src/components/Checkbox/Checkbox.types.ts
BaseboxProps extended with appearance, size, view, focused, checkIcon, indeterminateIcon, and deprecated readOnly; CheckboxProps now omits both size and readOnly from InputHTMLAttributes.
PropsTable readOnly exclusion in template and site docs
packages/plasma-new-hope/src/components/Checkbox/Checkbox.template-doc.mdx, packages/plasma-new-hope/src/components/Radiobox/Radiobox.template-doc.mdx, website/plasma-b2c-docs/docs/components/Checkbox.mdx, website/plasma-b2c-docs/docs/components/Radiobox.mdx, website/plasma-giga-docs/docs/components/..., website/plasma-homeds-docs/docs/components/..., website/plasma-web-docs/docs/components/..., website/sdds-*/docs/components/Checkbox.mdx, website/sdds-*/docs/components/Radiobox.mdx
Adds readOnly to the exclude list of every PropsTable component call in the template and all per-site MDX docs for both Checkbox and Radiobox.
Usage section and caution block formatting
website/plasma-b2c-docs/docs/components/Checkbox.mdx, website/plasma-web-docs/docs/components/Checkbox.mdx, website/sdds-cs-docs/docs/components/Checkbox.mdx, website/sdds-insol-docs/docs/components/Checkbox.mdx, website/sdds-serv-docs/docs/components/Checkbox.mdx
Reformats JSX props (label/description) from single-line to multi-line layout and normalizes whitespace in view deprecation caution blocks and code-fence delimiters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

sdds-sbcom

Suggested reviewers

  • TitanKuzmich
  • shuga2704
  • IgorYar

Poem

🐇 A readOnly prop now wears a ✨deprecated✨ sign,
Snipped from the table, no longer to shine.
Across thirteen sites, the PropsTable aligns,
With multiline labels and tidy defines.
The bunny hops onward — the docs look divine! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and specifically describes the main change: marking the readOnly property as deprecated in Plasma components, which aligns with the core objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch PLASMA-5873

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/plasma-new-hope/src/components/Checkbox/Checkbox.template-doc.mdx

Parsing error: Expression expected.

packages/plasma-new-hope/src/components/Radiobox/Radiobox.template-doc.mdx

Parsing error: Expression expected.

website/plasma-b2c-docs/docs/components/Checkbox.mdx

Parsing error: Expression expected.

  • 25 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Yakutoc Yakutoc changed the title Plasma 5873 PLASMA-5873: Свойство readOnly помечено как deprecated Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-2895/

@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-2895/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-2895/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-2895/b2c-storybook/
giga storybook: https://plasma.sberdevices.ru/pr/pr-2895/giga-storybook/
homeds storybook: https://plasma.sberdevices.ru/pr/pr-2895/homeds-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-2895/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-2895/web-storybook/
sdds-bizcom storybook: https://plasma.sberdevices.ru/pr/pr-2895/sdds-bizcom-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-2895/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-2895/sdds-dfa-storybook/
sdds-finai storybook: https://plasma.sberdevices.ru/pr/pr-2895/sdds-finai-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-2895/sdds-insol-storybook/
sdds-netology storybook: https://plasma.sberdevices.ru/pr/pr-2895/sdds-netology-storybook/
sdds-os storybook: https://plasma.sberdevices.ru/pr/pr-2895/sdds-os-storybook/
sdds-platform-ai storybook: https://plasma.sberdevices.ru/pr/pr-2895/sdds-platform-ai-storybook/
sdds-sbcom storybook: https://plasma.sberdevices.ru/pr/pr-2895/sdds-sbcom-storybook/
sdds-scan storybook: https://plasma.sberdevices.ru/pr/pr-2895/sdds-scan-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-2895/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-2895/ui-storybook/

@Yakutoc Yakutoc marked this pull request as ready for review June 18, 2026 06:53
@Yakutoc Yakutoc requested review from IgorYar and TitanKuzmich June 18, 2026 07:10
@Yakutoc Yakutoc added this pull request to the merge queue Jun 22, 2026
Merged via the queue into dev with commit a8b4756 Jun 22, 2026
60 checks passed
@Yakutoc Yakutoc deleted the PLASMA-5873 branch June 22, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants