PLASMA-7120: changelog for sdds-finai by oki1oki · Pull Request #2888 · salute-developers/plasma

oki1oki · 2026-06-16T16:27:12Z

SDDS-FINAI

Button, Link

изменения согласно changelog

What/why changed

изменения согласно changelog

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.381.0-canary.2888.27632408056.0
npm install @salutejs/plasma-b2c@1.623.0-canary.2888.27632408056.0
npm install @salutejs/plasma-giga@0.350.0-canary.2888.27632408056.0
npm install @salutejs/plasma-homeds@0.350.0-canary.2888.27632408056.0
npm install @salutejs/plasma-hope@1.377.0-canary.2888.27632408056.0
npm install @salutejs/plasma-new-hope@0.367.0-canary.2888.27632408056.0
npm install @salutejs/plasma-web@1.625.0-canary.2888.27632408056.0
npm install @salutejs/sdds-bizcom@0.355.0-canary.2888.27632408056.0
npm install @salutejs/sdds-cs@0.359.0-canary.2888.27632408056.0
npm install @salutejs/sdds-dfa@0.353.0-canary.2888.27632408056.0
npm install @salutejs/sdds-finai@0.346.0-canary.2888.27632408056.0
npm install @salutejs/sdds-insol@0.350.0-canary.2888.27632408056.0
npm install @salutejs/sdds-netology@0.354.0-canary.2888.27632408056.0
npm install @salutejs/sdds-os@0.25.0-canary.2888.27632408056.0
npm install @salutejs/sdds-platform-ai@0.354.0-canary.2888.27632408056.0
npm install @salutejs/sdds-sbcom@0.355.0-canary.2888.27632408056.0
npm install @salutejs/sdds-scan@0.353.0-canary.2888.27632408056.0
npm install @salutejs/sdds-serv@0.354.0-canary.2888.27632408056.0
npm install @salutejs/sdds-api-tests@0.12.0-canary.2888.27632408056.0
# or 
yarn add @salutejs/plasma-asdk@0.381.0-canary.2888.27632408056.0
yarn add @salutejs/plasma-b2c@1.623.0-canary.2888.27632408056.0
yarn add @salutejs/plasma-giga@0.350.0-canary.2888.27632408056.0
yarn add @salutejs/plasma-homeds@0.350.0-canary.2888.27632408056.0
yarn add @salutejs/plasma-hope@1.377.0-canary.2888.27632408056.0
yarn add @salutejs/plasma-new-hope@0.367.0-canary.2888.27632408056.0
yarn add @salutejs/plasma-web@1.625.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-bizcom@0.355.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-cs@0.359.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-dfa@0.353.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-finai@0.346.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-insol@0.350.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-netology@0.354.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-os@0.25.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-platform-ai@0.354.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-sbcom@0.355.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-scan@0.353.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-serv@0.354.0-canary.2888.27632408056.0
yarn add @salutejs/sdds-api-tests@0.12.0-canary.2888.27632408056.0

Summary by CodeRabbit

New Features
- List component now offers simplified item divider configuration for improved content separation.
Improvements
- Enhanced list item divider styling with refined spacing and positioning controls.
- Removed deprecated button size variants from SDDS FinAI design system.
Documentation
- Updated List component documentation to reflect simplified divider usage patterns.

coderabbitai · 2026-06-16T16:27:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b87e2f7e-05a6-4b2c-8c9e-a988f2841be1

📥 Commits

Reviewing files that changed from the base of the PR and between a53e74b and db47170.

📒 Files selected for processing (7)

packages/plasma-homeds/src/components/List/List.config.ts
packages/plasma-new-hope/src/components/List/List.tokens.ts
packages/plasma-new-hope/src/components/List/ui/ListItem.styles.tsx
packages/sdds-finai/src/components/Button/Button.config.ts
packages/sdds-finai/src/components/List/List.config.ts
packages/sdds-finai/src/components/List/List.stories.tsx
website/sdds-finai-docs/docs/components/List.mdx

💤 Files with no reviewable changes (1)

packages/sdds-finai/src/components/Button/Button.config.ts

📝 Walkthrough

Walkthrough

Replaces the listItemDividerWidth token with listItemDividerHeight, listItemDividerMarginTop, and listItemDividerMarginBottom tokens in plasma-new-hope, updates ListItem styled-component divider positioning logic accordingly, propagates new token assignments to plasma-homeds and sdds-finai List configs, migrates sdds-finai divider coverage from a standalone story to a hasDivider arg, and removes deprecated xl/l/m Button size variants in sdds-finai.

Changes

List Divider Token Refactor

Layer / File(s)	Summary
Token contract and ListItem styling `packages/plasma-new-hope/src/components/List/List.tokens.ts`, `packages/plasma-new-hope/src/components/List/ui/ListItem.styles.tsx`	Removes `listItemDividerWidth` from `tokens` and adds `listItemDividerHeight`, `listItemDividerMarginTop`, `listItemDividerMarginBottom`. Updates `StyledListItem` to compute `margin-bottom` from the new tokens and reposition the `::after` pseudo-element using height and margin values.
Package config token assignments `packages/plasma-homeds/src/components/List/List.config.ts`, `packages/sdds-finai/src/components/List/List.config.ts`	plasma-homeds removes `listItemDividerWidth` from `view.default` and adds `listItemDividerHeight` to `size.s`/`size.m`. sdds-finai adds `listItemDividerColor` to `view.default` and sets `listItemDividerHeight` plus top/bottom margins for all four size variants (`xs`, `s`, `m`, `l`).
Storybook and docs migration to `hasDivider` prop `packages/sdds-finai/src/components/List/List.stories.tsx`, `website/sdds-finai-docs/docs/components/List.mdx`	Removes the `Divider` import and `WithDivider` exported story; adds a `hasDivider` boolean argType control and sets `hasDivider: false` in `Default` args. Updates the `List.mdx` base-usage example to use `hasDivider` on `List` instead of manually placed `Divider` components.

sdds-finai Button Size Cleanup

Layer / File(s)	Summary
Remove deprecated Button size variants `packages/sdds-finai/src/components/Button/Button.config.ts`	Drops the `xl`, `l`, and `m` entries from `config.variations.size`, leaving `s`, `xs`, and `xxs` as the remaining size options (72 lines removed).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

TitanKuzmich
Yakutoc

Poem

🐇 The divider once was wide, now it stands tall,
With height and margins measured for each call.
Old sizes for buttons? Gone with a hop!
hasDivider replaces stories that stop.
The rabbit refactors, tokens align—
Everything measured, everything fine! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title mentions only changelog entries for sdds-finai, but the changeset includes substantial component changes across multiple files including List and Button configuration/styling updates in multiple packages (plasma-homeds, plasma-new-hope, sdds-finai) plus documentation changes.	Update the title to reflect the primary changes, such as 'PLASMA-7120: Update List divider styling and Button size configuration' or include the scope of component changes rather than just changelog documentation.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch PLASMA-7120

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

website/sdds-finai-docs/docs/components/List.mdx

Parsing error: Expression expected.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-06-16T16:30:16Z

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-2888/

github-actions · 2026-06-16T17:18:57Z

Documentation preview deployed!

TitanKuzmich · 2026-06-18T10:16:57Z

-            /**
-             * @deprecated
-             */
-            xl: css`


Точно это убираем?

По changelog - да

TitanKuzmich · 2026-06-18T10:17:28Z

                ${listTokens.listItemFocusColor}: var(--surface-accent);
                ${listTokens.listBackground}: var(--surface-transparent-primary);
                ${listTokens.listItemDividerColor}: var(--surface-transparent-primary);
-                ${listTokens.listItemDividerWidth}: 0.0625rem;


Только в этом конфиге во view лежал такой токен?

Да, у других вертикалей в макетах нет divider

Yakutoc · 2026-06-18T12:43:10Z

ок получен от продукта

oki1oki added 2 commits June 16, 2026 19:23

feat(new-hope): update List Divider [PLASMA-7120]

9782b28

feat(sdds-finai): changelog for Button & List [PLASMA-7120]

db47170

oki1oki self-assigned this Jun 16, 2026

oki1oki added the sdds-finai label Jun 16, 2026

oki1oki temporarily deployed to internal June 16, 2026 16:27 — with GitHub Actions Inactive

oki1oki marked this pull request as ready for review June 17, 2026 06:14

oki1oki requested review from TitanKuzmich, Yakutoc, Yeti-or, neretin-trike and shuga2704 as code owners June 17, 2026 06:14

oki1oki requested review from IgorYar and removed request for Yakutoc, Yeti-or, neretin-trike and shuga2704 June 17, 2026 06:15

github-actions Bot removed the request for review from TitanKuzmich June 17, 2026 06:15

oki1oki requested a review from TitanKuzmich June 17, 2026 06:18

TitanKuzmich reviewed Jun 18, 2026

View reviewed changes

IgorYar approved these changes Jun 18, 2026

View reviewed changes

Yakutoc approved these changes Jun 18, 2026

View reviewed changes

TitanKuzmich approved these changes Jun 18, 2026

View reviewed changes

oki1oki added this pull request to the merge queue Jun 19, 2026

Merged via the queue into dev with commit 6c5f0fa Jun 19, 2026
82 of 87 checks passed

oki1oki deleted the PLASMA-7120 branch June 19, 2026 13:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PLASMA-7120: changelog for sdds-finai#2888

PLASMA-7120: changelog for sdds-finai#2888
oki1oki merged 2 commits into
devfrom
PLASMA-7120

oki1oki commented Jun 16, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 16, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

TitanKuzmich Jun 18, 2026

Uh oh!

oki1oki Jun 18, 2026

Uh oh!

TitanKuzmich Jun 18, 2026

Uh oh!

oki1oki Jun 18, 2026

Uh oh!

Yakutoc commented Jun 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

oki1oki commented Jun 16, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDDS-FINAI

Button, Link

What/why changed

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

TitanKuzmich Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

oki1oki Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

TitanKuzmich Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

oki1oki Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

Yakutoc commented Jun 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oki1oki commented Jun 16, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 16, 2026 •

edited

Loading