test(plasma-new-hope): Button red background for CI coverage check#2887
test(plasma-new-hope): Button red background for CI coverage check#2887Yeti-or wants to merge 1 commit into
Conversation
…heck Temporary change to verify which Cypress and Storybook jobs run per library when plasma-new-hope Button styles change. Co-authored-by: Cursor <cursoragent@cursor.com>
Yeti-or
requested review from
TitanKuzmich,
Yakutoc,
neretin-trike and
shuga2704
as code owners
📝 WalkthroughWalkthroughIn ChangesButton Base View Background
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/plasma-new-hope/src/components/Button/variations/_view/base.ts`:
- Line 7: Remove all hardcoded background: red declarations from the Button base
states file (located at lines 7, 11, 18, and 27). Replace these with proper
state token references that follow the state token contract for
default/loading/hover/active states instead. Ensure that the shared Button base
styles use the appropriate design tokens rather than hardcoded values to prevent
visual regressions across libraries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 68608359-dc24-4767-b425-40f5e16a7485
📒 Files selected for processing (1)
packages/plasma-new-hope/src/components/Button/variations/_view/base.ts
| export const base = css` | ||
| color: var(${tokens.buttonColor}); | ||
| background: var(${tokens.buttonBackgroundColor}); | ||
| background: red; |
There was a problem hiding this comment.
Do not leave hardcoded background: red in shared Button base states.
This bypasses the state token contract (default/loading/hover/active) and will ship a cross-library visual regression if accidentally merged. For this CI-probing goal, keep the probe outside runtime shared styles (or immediately revert these lines before merge readiness).
Also applies to: 11-11, 18-18, 27-27
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/plasma-new-hope/src/components/Button/variations/_view/base.ts` at
line 7, Remove all hardcoded background: red declarations from the Button base
states file (located at lines 7, 11, 18, and 27). Replace these with proper
state token references that follow the state token contract for
default/loading/hover/active states instead. Ensure that the shared Button base
styles use the appropriate design tokens rather than hardcoded values to prevent
visual regressions across libraries.
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-2887/ |
1 participant
Summary
redinplasma-new-hopeview base styles.Test plan
Made with Cursor
Summary by CodeRabbit
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @salutejs/plasma-asdk@0.380.1-canary.2887.27624291951.0 npm install @salutejs/plasma-b2c@1.622.1-canary.2887.27624291951.0 npm install @salutejs/plasma-giga@0.349.1-canary.2887.27624291951.0 npm install @salutejs/plasma-homeds@0.349.1-canary.2887.27624291951.0 npm install @salutejs/plasma-hope@1.376.1-canary.2887.27624291951.0 npm install @salutejs/plasma-new-hope@0.366.1-canary.2887.27624291951.0 npm install @salutejs/plasma-web@1.624.1-canary.2887.27624291951.0 npm install @salutejs/sdds-bizcom@0.354.1-canary.2887.27624291951.0 npm install @salutejs/sdds-cs@0.358.1-canary.2887.27624291951.0 npm install @salutejs/sdds-dfa@0.352.1-canary.2887.27624291951.0 npm install @salutejs/sdds-finai@0.345.1-canary.2887.27624291951.0 npm install @salutejs/sdds-insol@0.349.1-canary.2887.27624291951.0 npm install @salutejs/sdds-netology@0.353.1-canary.2887.27624291951.0 npm install @salutejs/sdds-os@0.24.1-canary.2887.27624291951.0 npm install @salutejs/sdds-platform-ai@0.353.1-canary.2887.27624291951.0 npm install @salutejs/sdds-sbcom@0.354.1-canary.2887.27624291951.0 npm install @salutejs/sdds-scan@0.352.1-canary.2887.27624291951.0 npm install @salutejs/sdds-serv@0.353.1-canary.2887.27624291951.0 npm install @salutejs/sdds-api-tests@0.11.1-canary.2887.27624291951.0 # or yarn add @salutejs/plasma-asdk@0.380.1-canary.2887.27624291951.0 yarn add @salutejs/plasma-b2c@1.622.1-canary.2887.27624291951.0 yarn add @salutejs/plasma-giga@0.349.1-canary.2887.27624291951.0 yarn add @salutejs/plasma-homeds@0.349.1-canary.2887.27624291951.0 yarn add @salutejs/plasma-hope@1.376.1-canary.2887.27624291951.0 yarn add @salutejs/plasma-new-hope@0.366.1-canary.2887.27624291951.0 yarn add @salutejs/plasma-web@1.624.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-bizcom@0.354.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-cs@0.358.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-dfa@0.352.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-finai@0.345.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-insol@0.349.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-netology@0.353.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-os@0.24.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-platform-ai@0.353.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-sbcom@0.354.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-scan@0.352.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-serv@0.353.1-canary.2887.27624291951.0 yarn add @salutejs/sdds-api-tests@0.11.1-canary.2887.27624291951.0