Implement logging using built-in logging library#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors logging throughout the
cache_managerpackage to use Python's standardloggingmodule instead of the custom_logfunction. The changes improve consistency, flexibility, and integration with external logging systems. The main updates include replacing all_logcalls withlogger.debug, introducing module-level loggers, and removing_logimports.Logging refactor in
cache_manager/_cache.py:_logwithlogger.debugfor logging messages throughout theCacheclass and related functions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30] [31]cache_manager/_cache.pyand removed the_logimport. [1] [2]Logging refactor in
cache_manager/_freshness.py:_logwithlogger.debugin the_check_etagfunction and removed the_logimport. [1] [2]cache_manager/_freshness.py.API cleanup:
logand_logexports fromcache_manager/__init__.pyto reflect the removal of the custom logging function.