fix: minor code fixes#769
Merged
Merged
Conversation
Modifiers at the end of a regex should not have whitespace before them. Change "# xi" to just "#xi". Date format "t" returns a string that is the numbers of days in the month. Explicitly cast it to int when using it in a calculation. These were two minor things pointed out by my editor. Existing tests will cover the changes here. There is no actual bug being fixed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #769 +/- ##
=========================================
Coverage 98.66% 98.66%
Complexity 1757 1757
=========================================
Files 71 71
Lines 5163 5163
=========================================
Hits 5094 5094
Misses 69 69 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifiers at the end of a regex should not have whitespace before them. Change "# xi" to just "#xi".
Date format "t" returns a string that is the numbers of days in the month. Explicitly cast it to int when using it in a calculation.
These were two minor things pointed out by my editor. Existing tests will cover the changes here. There is no actual bug being fixed.