feat: preserve UTC 'Z' indicator in Period JSON serialization#765
Open
bastien-roucaries wants to merge 2 commits into
Open
feat: preserve UTC 'Z' indicator in Period JSON serialization#765bastien-roucaries wants to merge 2 commits into
bastien-roucaries wants to merge 2 commits into
Conversation
phil-davis
reviewed
May 31, 2026
| if ('P' === $end[0]) { | ||
| $return[] = [ | ||
| $start->format('Y-m-d\\TH:i:s'), | ||
| $start->format('Y-m-d\\TH:i:s').$zSuffix, |
Contributor
There was a problem hiding this comment.
In this case the "date"-time string is a duration, so a timezone indication is not relevant.
Something like "1970-01-02:14:30:00" just indicates a duration of 1 day, 14 hours, 30 miutes and 0 seconds.
Or am I not understanding?
Author
There was a problem hiding this comment.
@phil-davis for end, not for start that should use timezone
When serializing PERIOD values to JSON (for jCal format), preserve the 'Z' timezone indicator for UTC datetimes. This ensures FREEBUSY periods maintain explicit UTC designation, avoiding timezone ambiguity. Without this change: FREEBUSY:20120226T230000Z/20120226T230000Z => serializes to: ["2012-02-26T23:00:00", "2012-02-26T23:00:00"] With this change: FREEBUSY:20120226T230000Z/20120226T230000Z => serializes to: ["2012-02-26T23:00:00Z", "2012-02-26T23:00:00Z"] This behavior is consistent with RFC 5545 which requires UTC times to be designated with the 'Z' suffix. Related: sabre-io#411
…json serialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When serializing PERIOD values to JSON (for jCal format), preserve the 'Z' timezone indicator for UTC datetimes. This ensures FREEBUSY periods maintain explicit UTC designation, avoiding timezone ambiguity.
Without this change:
FREEBUSY:20120226T230000Z/20120226T230000Z
=> serializes to: ["2012-02-26T23:00:00", "2012-02-26T23:00:00"]
With this change:
FREEBUSY:20120226T230000Z/20120226T230000Z
=> serializes to: ["2012-02-26T23:00:00Z", "2012-02-26T23:00:00Z"]
This behavior is consistent with RFC 5545 which requires UTC times to be designated with the 'Z' suffix.
Related: #411