fix(ci): declare SENTRY_AUTH_TOKEN as passthrough env for build - #6
Merged
Conversation
Vercel warns when a project env var isn't declared in turbo.json. The token only affects the Sentry build plugin's source-map upload as a side effect -- it never changes build output -- so it's added via passThroughEnv (available to the build task, excluded from the cache hash) rather than env, which would invalidate the build cache on every token rotation for no reason.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SENTRY_AUTH_TOKENis set on the Vercel project but not declared inturbo.json.buildtask'spassThroughEnv(notenv): the token only drives the Sentry build plugin's source-map upload as a side effect and never changes the build's actual output, so it shouldn't be hashed into the cache key. Usingenvinstead would invalidate the build cache every time the token rotates, for no reason.buildtask only — no other tasks/dependencies/outputs touched, caching is untouched (confirmed below).Test plan
pnpm build— 8/8 tasks pass, no warningspnpm buildrun a second time — 8/8 cached (FULL TURBO), confirming caching still worksnode scripts/ci-verify.mjs— all steps passednpx prettier --check turbo.json— clean🤖 Generated with Claude Code