Skip to content

chore(deps): refresh pnpm lockfile, drop legacy sidecar binary, link portable skills#12

Closed
saagpatel wants to merge 1 commit into
mainfrom
feat/deps-refresh-2026-05
Closed

chore(deps): refresh pnpm lockfile, drop legacy sidecar binary, link portable skills#12
saagpatel wants to merge 1 commit into
mainfrom
feat/deps-refresh-2026-05

Conversation

@saagpatel
Copy link
Copy Markdown
Owner

Summary

  • Regenerated pnpm-lock.yaml (compatibility refresh, ~5,148 lines)
  • Removed vendored 80MB sidecar src-tauri/binaries/jcc-sidecar-aarch64-apple-darwin (build artifact, not source)
  • Linked 4 portable skills (api-design, migration, notarize, tauri-release) as symlinks under .claude/skills/
  • Added CLAUDE.md (+39 lines)

Why

Captures mid-flight WIP that was sitting uncommitted in the working tree. The sidecar binary doesn't belong in version control (it's a build output, restorable via the Tauri build pipeline).

Test plan

  • CI passes
  • Local pnpm install --frozen-lockfile succeeds with the regenerated lockfile
  • Tauri sidecar can be regenerated from build pipeline (sanity check, not blocking)
  • No production code paths reference the removed binary

🤖 Generated with Claude Code

…portable skills

- pnpm-lock.yaml regenerated
- Deleted vendored 80MB jcc-sidecar binary (build artifact, not source)
- Linked 4 portable skills (api-design, migration, notarize, tauri-release)
- CLAUDE.md additions

Mid-flight WIP captured for review; not pushed.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c2e3f8ad06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/skills/api-design
@@ -0,0 +1 @@
/Users/d/.claude/portable-skills/api-design No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace machine-local skill symlinks

On any checkout that is not on the original /Users/d machine, this symlink (and the other newly added .claude/skills/* symlinks) resolves to a non-existent absolute path, so the committed skills are unusable and can trip tooling that traverses skill directories as dangling links. Since these are meant to be repository-portable skills, commit relative links or the actual skill directories instead of absolute local paths.

Useful? React with 👍 / 👎.

@saagpatel
Copy link
Copy Markdown
Owner Author

Closing in favor of a fresh PR off rebased base — see PR coming next. (Branch had stale base off pre-PR-#7/#8 main; force-push hook-blocked, so re-opening with new branch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant