Skip to content

Fix URL validation in SocialsForm #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Discusser wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Fix URL validation in SocialsForm #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 4 additions & 60 deletions src/lib/schemas/socials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,64 +1,8 @@
import { SocialsInputType } from '$lib/constants/socials';
import { findSocial } from '$lib/utils/handleSocialClick';
import { z } from 'zod';

export const socialsSchema = z
.object({
social: z.string().min(1).max(60),
socialURL: z.string().min(1).max(200)
})
.superRefine((obj, ctx) => {
const socialObject = findSocial(obj.social);
if (socialObject?.inputType !== SocialsInputType.URL) {
return;
}
if (!obj.socialURL) return;

const URLPattern = new RegExp(
'(https:\\/\\/www\\.|http:\\/\\/www\\.|https:\\/\\/|http:\\/\\/)?[a-zA-Z0-9]{2,}(\\.[a-zA-Z0-9]{2,})(\\.[a-zA-Z0-9]{2,})?'
);

const isUrlValid = URLPattern.test(obj.socialURL);

if (!isUrlValid) {
ctx.addIssue({
code: z.ZodIssueCode.invalid_string,
message: 'Invalid URL',
path: ['socialURL'],
validation: 'url'
});
return;
}

// cleanup the URL by adding https:// if it's not already there
let url = obj.socialURL;

if (!(url.startsWith('http://') || url.startsWith('https://'))) {
url = 'https://' + url;
}

// extract the domain from the URL
const domain = new URL(url).hostname;

if (socialObject.domains.includes(domain)) {
return true;
}

ctx.addIssue({
code: z.ZodIssueCode.invalid_string,
message: 'URL provided is not a valid domain for the selected social',
validation: 'url',
path: ['socialURL']
});
})
.transform((data) => {
if (findSocial(data.social)?.inputType !== SocialsInputType.URL) return data;

// cleanup the URL by adding https:// if it's not already there
if (!(data.socialURL.startsWith('http://') || data.socialURL.startsWith('https://'))) {
data.socialURL = 'https://' + data.socialURL;
}
return data;
});
export const socialsSchema = z.object({
social: z.string().min(1).max(60),
socialURL: z.string().min(1).max(200).url()
});

export type SocialsSchema = typeof socialsSchema;