refactor: replace JSON3 with JSON for deprecation note#2
Open
AbrJA wants to merge 2 commits into
Open
Conversation
Open
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase to replace the JSON3 dependency with JSON.jl for reading/parsing JSON in both the library code and the test suite.
Changes:
- Swap JSON3 usage to JSON.jl (
JSON.parse) in type definition loading and fixture/test parsing. - Update tests to use string-key access patterns consistent with JSON.jl’s parsed objects.
- Update
Project.tomldependencies/compat to depend onJSONinstead ofJSON3.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/type_definitions.jl |
Switches type definition JSON parsing from JSON3 to JSON.jl. |
test/test_type_definitions.jl |
Updates schema/type-definition parsing and expected qualifier extraction to use JSON.jl structures. |
test/fixtures.jl |
Updates fixture loader to parse with JSON.jl and use string keys throughout. |
test/runtests.jl |
Replaces using JSON3 with using JSON for the test harness. |
Project.toml |
Replaces the JSON3 dependency and compat entry with JSON.jl. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks @AbrJA for this and toon-format/ToonFormat.jl#16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.