Initialize developer mode variable without resorting to hard coding - #2
Open
michaesc wants to merge 10 commits into
Open
Initialize developer mode variable without resorting to hard coding#2michaesc wants to merge 10 commits into
michaesc wants to merge 10 commits into
Conversation
Change-Id: I09b9267b805816becf400119ec51fce033e70f92 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Change-Id: Id97f84d90e2cbaed48d60269ad2371f0f1f068c0 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Change-Id: I17c163a3add102d139c72afc84c4d6bff85eb02a Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Change-Id: Idd590e8e03120287d0ea58574fa9c08435d1bc76 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Change-Id: I3395efa3a5fc309a4dc7a6863c56fed78befe287 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Change-Id: I9454aba4d8a5d30361aaff0a929285a0fa492f82 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Change-Id: Ibe35bd199d2205756a982e300cde517ebc5a2fb7 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Change-Id: I38d1eabd40bf99253fcd545c3095237b29b9e455 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Change-Id: I08b237a4e7fbb8fafb176d8d58bab034165e225e Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
michaesc
changed the title
rzr
pushed a commit
that referenced
this pull request
Mar 29, 2016
Bug: #2 Change-Id: Ie9729ec8f434a9b9b2efceab4a3019dcff76e588
Owner
|
I picked your changes, please rebase master on your branch and test on ffos too. |
Author
|
Thanks for merging, I'll rebase the Foxos branch or close it since master inherits Foxos logic. Yes, the market is still open to new apps, so I'll test as you suggest to prepare for imminent submission. |
Owner
|
Maybe this place would be the best place to push your changes without reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes refer to an improvement rather than correction, since hard coding 'isAdvanced = !false' forces future changes to the UI to be done in two places while preventing persistent storage. There's some work to do in making dom storage, local storage, and JS variables consistent, so that's noted in comment.