Skip to content

sea miles#18

Open
unnu wants to merge 1 commit into
ryanong:masterfrom
unnu:master
Open

sea miles#18
unnu wants to merge 1 commit into
ryanong:masterfrom
unnu:master

Conversation

@unnu

@unnu unnu commented Jan 30, 2012

Copy link
Copy Markdown

Hi Ryan,

I just added the sea mile factor to EARTH_RADIUS.

Cheers,
Norman

@ryanong

ryanong commented Jan 31, 2012

Copy link
Copy Markdown
Owner

I am actually thinking of using this library I worked on recently to handle this issue.
https://github.com/minad/unit hopefully we won't need this absurd calculations anymore. I'll keep this open though to remind me to implement sea miles in unit

@unnu

unnu commented Jan 31, 2012

Copy link
Copy Markdown
Author

Will you switch to unit in the next release of mongoid_spacial?

@ryanong

ryanong commented Jan 31, 2012

Copy link
Copy Markdown
Owner

I am doing a huge refactor sometime in the next two to three weeks
On Jan 31, 2012 8:59 AM, "unnu" <
reply@reply.github.com>
wrote:

Will you switch to unit in the next release of mongoid_spacial?


Reply to this email directly or view it on GitHub:
#18 (comment)

@unnu

unnu commented Jan 31, 2012

Copy link
Copy Markdown
Author

I'm asking that because I'd like to get rid of m fork as soon as possible. Since it's only one line of code, could you merge my patch before your refactoring?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants