Skip to content

Input manager#37

Open
BIightning wants to merge 15 commits into
ryankurte:masterfrom
VISCON-GmbH:input-manager
Open

Input manager#37
BIightning wants to merge 15 commits into
ryankurte:masterfrom
VISCON-GmbH:input-manager

Conversation

@BIightning

@BIightning BIightning commented Sep 22, 2024

Copy link
Copy Markdown
Contributor

Implemented input events as discussed in #33.

Tested functionality with StreamDeck Plus and Mini.

@BIightning

BIightning commented Sep 22, 2024

Copy link
Copy Markdown
Contributor Author

Thinking about it again, I am not sure if introducing lifetimes into the library by letting the Input Manager instance hold a mutable ref to a deck is a good idea, we could just move the deck into the manager, make it public and access it via manager.deck if we need it.

That would be much easier to use imo.

What do you think @ryankurte ?

@ryankurte

ryankurte commented Sep 22, 2024

Copy link
Copy Markdown
Owner

hey overall looks good, i think you are correct about it is more straightforward to just pass the deck instance into the manager (so long as it remains optional as not to break existing uses), and if folks have more complex needs we can look at that in the future (or it can be implemented outside the library).

@BIightning

Copy link
Copy Markdown
Contributor Author

Hey @ryankurte, I finally changed the input manager api as discussed. Also gated everything behind a feature flag.

Tested on Streamdeck Plus & Mini.

@ryankurte ryankurte left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a rebase now (sorry) but looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants