Skip to content

Finished 0.11.4 - #205

Merged
thosgood merged 8 commits into
ryankeleti:masterfrom
wayneyang108:master
Nov 22, 2023
Merged

Finished 0.11.4#205
thosgood merged 8 commits into
ryankeleti:masterfrom
wayneyang108:master

Conversation

@wayneyang108

@wayneyang108 wayneyang108 commented Nov 14, 2023

Copy link
Copy Markdown

11/13:
Update link between \sref and \label.
Correct and add proposition 5.2.2.
I will start working on the remaining EGA3 translation.
11/14:
Complete 0.11.3.4 to 0.11.3.6 and add title for 0.11.4 to 0.11.10
11/15:
Finished 0.11.4

@wayneyang108 wayneyang108 changed the title Update link between \sref and \label. Correct and add proposition 5.2.2. Finished 0.11.4 Nov 15, 2023
@thosgood

thosgood commented Nov 15, 2023

Copy link
Copy Markdown
Collaborator

this is great, thank you! let me know when you've finished and are happy for me to look at changes and them merge :-) I'm going to convert this to a draft pull request until then (just so I don't accidentally merge it!)

@thosgood
thosgood marked this pull request as draft November 15, 2023 16:02
@thosgood thosgood self-assigned this Nov 15, 2023
@thosgood

Copy link
Copy Markdown
Collaborator

just to be clear, which parts are you planning to work on? I'll update the main README with your name so nobody else duplicates the work (I think I was slowly starting on EGA III §2 (#203) a while back)

@wayneyang108

Copy link
Copy Markdown
Author

Thank you, I would like to update 0.11, 0.12, 0.13. I noticed that 0.11 was assigned to ryankeleti. Perhaps, I should jump to 0.12 to avoid conflicts?
I think I would stop here for a while, so this PR can be reviewed and merged. Just a start to see how can I improve my wording, notation and contribute to this project.

@thosgood

Copy link
Copy Markdown
Collaborator

ok, I'm away at the moment but when I'm back next week I'll take a look at this and merge it, thank you!

@ryankeleti

ryankeleti commented Nov 16, 2023

Copy link
Copy Markdown
Owner

Thanks for contributing! :) I can also review later

@thosgood
thosgood marked this pull request as ready for review November 21, 2023 08:41
@thosgood

thosgood commented Nov 21, 2023

Copy link
Copy Markdown
Collaborator

I've proofread and made changes, but I haven't tried locally building it yet to check that there aren't any tex errors. I'll do that at some point later this week and then merge :-) thanks again!

p.s. @wayneyang108 I added what I guess is your name to the list of contributors (https://github.com/ryankeleti/ega/pull/205/files#diff-ade7d2f0db76f7dc0eef2e96386859ee766b144d13448e2e177a049ffbbdc02a) but let me know if you want it changed

@wayneyang108

Copy link
Copy Markdown
Author

Thank you, the name is good.
Reviews are looking good and very helpful for my later context.
One thing is that I think \cx and \bcx are good abbreviation variables for indeterminate complex and bicomplex.
It would be nice if I can continue using them.

@thosgood

Copy link
Copy Markdown
Collaborator

One thing is that I think \cx and \bcx are good abbreviation variables for indeterminate complex and bicomplex. It would be nice if I can continue using them.

You can use them if you like, since it takes me very little time to swap them for default latex. I agree that they're helpful commands when writing, but I'm trying to keep as much consistency as possible throughout the entire project, so I'm a bit hesitant to introduce new commands like this at this point in time.

@thosgood
thosgood merged commit 759adc9 into ryankeleti:master Nov 22, 2023
@wayneyang108

Copy link
Copy Markdown
Author

Good to hear that.
Thank you for merging it.
I am starting 0.11.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants