fix(fast-mode): gate seed close on clean lint + passed tests; tester fails on collection errors#21
Draft
ryanholtschneider2 wants to merge 1 commit into
Draft
Conversation
…fails on collection errors (po-formulas-software-dev-7fl) software_dev_fast auto-closed the seed regardless of verdict — including when a verdict was *empty* (the step never wrote a verdict file). That blind spot let 6 real test regressions through the pd-17lv CDR-A series: 9 test modules failed to import while the tester still reported 'passed', and every child closed with an empty lint verdict. - Fast-mode now closes the seed only when lint == 'clean' AND unit == 'passed'. Empty or non-clean/non-passed verdicts leave the seed open and return status='needs-review'. Matches the flow's own docstring. - Tester task.md: run 'pytest --collect-only' first, report a collection_errors count, and treat collection_errors >= 1 (a module that won't import) as a hard FAILED rather than a silent skip. - New tests cover the close gate (empty/failed verdicts block close) and the tester prompt contract. README updated.
ryanholtschneider2
marked this pull request as draft
June 14, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes
po-formulas-software-dev-7fl. Two independent gates let 6 real test regressions slip through 7 agent-step gates during the pd-17lv CDR-A epic series.Root cause
software_dev_fastauto-closed the seed regardless of verdict — including when a verdict was empty (the lint/test step never wrote a verdict file, i.e. didn't run / unknown). It only logged a warning, never gated the close.passedoff the tests that ran while 9 modules dropped onModuleNotFoundError.Fix
parent/po_formulas/software_dev.py): close the seed only whenlint == "clean"ANDunit == "passed". Anything else — empty, non-clean, or non-passed — leaves the seed open and returnsstatus="needs-review"so the caller can re-dispatch or escalate tosoftware-dev-full. This makes the code match the flow's own docstring.parent/po_formulas/agents/tester/task.md): runpytest --collect-onlyfirst, report acollection_errorscount, and treatcollection_errors >= 1as a hard FAILED even if every collected test passed.Tests
New
parent/tests/test_software_dev_fast.py:status == needs-review(the exact incident)status == completed--collect-only+collection_errors-gates-on-fail presentFull pack unit suite: green except one pre-existing, order-dependent failure in
test_software_dev_pack_path_metadata.pythat fails identically on basemainin a full-suite run and passes standalone (unrelated to this change).Acceptance mapping
collection_errors; ≥1 fails the run.lint_verdictblocks fast-mode auto-close (downgrades toneeds-review).test_failed_unit_verdict_blocks_close).