Sticky nav, profile image slot, social links, and AEO/schema updates#36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
xandsubstackand updated the header layout inportfolio/build.mjsand the generated layout HTML.jsonLdPerson()withdescription,knowsAbout, andsameAssources and adding ajsonLdHomePage()that emits aProfilePagetied to the person schema.profileImageslot (withprofileImageAlt) that reads dimensions viagetImageDimensions()and renderswidth/heightattributes to avoid CLS, plus a checked-in SVG placeholder atportfolio/static/img/ryan-baumann-profile.svg.portfolio/style.cssto make the headerposition: sticky, enable horizontal nav scrolling, add.profile-imageand.proof-gridstyles, and ensure responsive images withheight: auto.portfolio/content/site.jsonandportfolio/content/pages/about.mdto tighten copy, add Caterpillar and proof points, and set ananswerEngineSummary.CHANGELOG.mdentries,LEARNINGS.mdadditions, and aTODO.mdchecklist describing the copy/trust pass.Testing
npm run build/node portfolio/build.mjs) and the generator completed and wrote updated pages without errors.npm test) to exercise CI-safe test behavior and the test suite completed successfully.ProfilePageandPersonJSON-LD, the homepage proof points, and the profile imagewidth/heightattributes during the build step.Codex Task