WIP: Multiple media queries - #27
Open
peterramsing wants to merge 2 commits into
Open
Conversation
This adds css in JSON format to the media query test file that will allow testing against it in order to realize finding multiple media queries. This also adds a failing test to try and specifically search for a media query.
I did some more Google searching after the previous commit and found a generator for the AST version of the CSS. I went ahead and created a vanilla CSS version for future use and included it in the project. I also updated the mistakes I had made when trying to make the AST version of the CSS by hand. This includes those fixes as well.
Owner
|
This looks like its on the right path. I would change the FYI, this is a good resource for working with CSS ASTs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For fixing #25
@ryanbahniuk I created this PR so that I can get some input on if I'm tackling this the right way. I'm not overly familiar with the AST syntax or how you have these test set up. I now have a test failing and am experimenting on getting it to pass but I'm certainly not familiar with this type of code (and am loving the challenge for sure!).
So, if you see this going completely off base or if I'm working in the wrong areas just let me know. I'll just keep working and ping you if I have any specific questions.
I'll update this PR description when it's no long a WIP