fix(settings): label refresh-interval field as Inventory, not Channels#66
Merged
Conversation
The "Channels refresh interval" setting and its description ("How often
the channel tracker re-queries Twitch...") were wrong: refreshMinMs/Max
feed useInventoryRefresh, which schedules the Drops *inventory* re-query
with jitter (default 60-70 min, hard 60-min floor). The channel tracker
runs on its own, hardcoded cadence (~90s, ~25s fallback poll) in
tracker.ts and is not configurable via this field.
- i18n (en + de): rename label to "Inventory refresh interval" and
rewrite the description to describe the inventory re-query.
- Remove the orphaned pre-refactor refresh-preset/advanced i18n cluster
(settings.refreshInterval, refreshHint, refreshPreset.*, refreshAdvanced*,
refreshMin/Max) in both locales — unused since the field became a simple
min/max minutes input; verified no references remain.
- Fix misleading "channel-refresh" comments in EnginePanel, formatters,
and refreshIntervalField (the cadence they describe is inventory).
No behavior change; copy/labels and dead-key cleanup only.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Settings field labeled "Channels refresh interval" (description: "How often the channel tracker re-queries Twitch (random jitter between min and max)") is mislabeled — it actually controls the inventory refresh, not channel tracking. This PR corrects the copy and removes orphaned i18n keys.
Why
refreshMinMs/refreshMaxMs(default 60–70 min, hard 60-min floor) feed onlyuseInventoryRefresh, which schedulesfetchInventory()with jitter and logs"inventory refresh scheduled/run".The channel tracker runs on its own hardcoded cadence in
tracker.ts—refreshMs ≈ 90s(normal),fallbackPollRefreshMs ≈ 25s— and is not configurable through this field. A 60-minute value for channel tracking wouldn't even make sense.The correct label
settings.refreshInterval = "Inventory refresh interval"actually still existed (unused) from before the design-overhaul refactor; the refactor introduced the newsettings.row.refreshInterval.*row and mislabeled it as "Channels", and commit1c2b7e9later propagated "channel-refresh" into code comments.Changes
settings.refreshInterval,refreshHint,refreshPreset.*,refreshAdvancedShow/Hide,refreshMin/Max(13 keys per locale). Verified by grep that nothing references them.EnginePanel.tsx,formatters.ts, andrefreshIntervalField.ts(×2).Not touched
tracker.tsare unchanged (not configurable; never the issue).settings.resetAutomation(a separate possibly-orphaned key) left out of scope.Verification
npm run typecheck(both tsconfigs): cleannpm test: 514 passed (en/de key parity preserved — same keys removed from both locales)npm run lint: 0 errors (only pre-existing warnings in unrelatedwatch/*hooks)Copy/labels and dead-key cleanup only — no behavior change.
🤖 Generated with Claude Code