Delay bootstrap reconnect until main menu#925
Merged
Conversation
Contributor
Author
|
Marking this as urgent for tester validation: bootstrap currently reconnects immediately after save creation before the client fully returns to the main menu, so this fix is intended to unblock the bootstrap flow. If maintainers agree, this likely fits the |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the bootstrap save flow to delay reconnecting (to upload the bootstrap save) until the client has fully returned to the RimWorld main menu / entry state.
Changes:
- Replace the immediate main-thread reconnect step with a
LongEventHandler.ExecuteWhenFinishedcallback afterGenScene.GoToMainMenu(). - Add a
ReconnectAfterReturningToMenugate that waits untilCurrent.ProgramState == ProgramState.EntryandCurrent.Game == nullbefore attempting to reconnect.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
notfood
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wait for the client to fully return to the main menu before reconnecting to upload the bootstrap save.
Testing