Fix bootstrap world map rotation#924
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes a Harmony patch that hooked GameComponentUtility.StartedNewGame to enqueue OnBootstrapMapInitialized. That hook fired during the vanilla colony-creation flow and caused the bootstrap configurator window to reopen (manifesting as the "world map rotation" issue). The remaining patches on MapComponentUtility.FinalizeInit, Root_Play.Start, and Root_Play.Update continue to drive the bootstrap state machine, so the deleted hook is redundant.
Changes:
- Delete
BootstrapStartedNewGamePatchto stop the bootstrap window from re-triggering during vanilla new-game flow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
notfood
added
fix
Contributor
Author
|
Still related to standalone server bootstrap behaviour |
notfood
added
the
standalone server
Member
|
I wasn't sure so I wanted to inspect it while I'm not sleepy. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the early bootstrap StartedNewGame hook so the bootstrap window does not reopen during the vanilla colony creation flow.
Testing