Reset bootstrap client mode after save upload#923
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the bootstrap configurator disconnect handling so client-side bootstrap state is torn down after save upload flow completion, preventing stale bootstrap state from affecting later singleplayer starts.
Changes:
- Adds
ExitBootstrapModeto reset bootstrap UI, upload, coordinator, and window state. - Tracks when save upload has started so disconnect handling can optionally clear pending upload state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Source/Client/Windows/BootstrapConfiguratorWindow.cs |
Adds bootstrap teardown/reset logic and routes disconnects through it. |
Source/Client/Windows/BootstrapConfiguratorWindow.BootstrapFlow.cs |
Adds upload-start disconnect tracking around save.zip upload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| ResetTransientUiState(resetServerDrivenState: true); | ||
| Find.WindowStack.TryRemove(this); | ||
| ExitBootstrapMode(clearPendingUploadState: closeBootstrapModeOnDisconnect); |
Contributor
Author
There was a problem hiding this comment.
Tecnically not an issue, reconnecting to the server will set it all up and go on with it
| { | ||
| try | ||
| { | ||
| closeBootstrapModeOnDisconnect = true; |
notfood
added
fix
Contributor
Author
|
Still related to standalone server bootstrap behaviour |
notfood
added
the
standalone server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing