chore(renovate): pin p-limit to v3 (CommonJS)#73
Merged
Conversation
p-limit v4+ is pure ESM with no CommonJS entry. The rw-backend plugin compiles to CommonJS and Backstage's CLI Jest setup does not transform p-limit, so a v4+ bump breaks `runWorker.test.ts` with "Cannot use import statement outside a module". Backstage's own backend packages (backend-defaults, plugin-catalog-backend) also stay on p-limit v3 for the same reason. This closes the Renovate PR proposing p-limit v7 and prevents future v4+ bumps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yumike
force-pushed
the
chore/pin-p-limit-v3
branch
from
6e7053a to
6fc313d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
p-limitto<4.0.0inrenovate.json.Why
p-limitv4+ is pure ESM ("type": "module", no CommonJS entry). Therw-backendplugin is a CommonJSbackend-plugin, and Backstage's CLI Jest config does not includep-limitin its transform allowlist. So bumping to v4+ breaksrunWorker.test.tsat load time with:Backstage's own backend packages stay on the v3 line for the same reason:
@backstage/backend-defaults^3.1.0@backstage/plugin-catalog-backend^3.0.2Our only usage (
runWorker.ts) ispLimit(CONCURRENCY)+limit(fn), which v3 covers fully — there's no feature in v4–v7 we need.Effect
🤖 Generated with Claude Code