audit: integrate 2026-07-25 remediation plan - #26
Conversation
… into Codex/audit-integration-20260727
…erator' into Codex/audit-integration-20260727
…' into Codex/audit-integration-20260727
…hortcuts' into Codex/audit-integration-20260727
…into Codex/audit-integration-20260727
…tion' into Codex/audit-integration-20260727
…stics' into Codex/audit-integration-20260727 # Conflicts: # apps/theme-manager/src/renderer/app.js # apps/theme-manager/src/renderer/index.html # docs/CHANGELOG.md
…bility' into Codex/audit-integration-20260727 # Conflicts: # docs/CHANGELOG.md # package.json # scripts/generate-themes.mjs # scripts/validate.mjs
…data' into Codex/audit-integration-20260727 # Conflicts: # apps/theme-manager/src-tauri/src/catalog.rs # docs/CHANGELOG.md # docs/adapters.md # package.json # schemas/registry.schema.json # scripts/capture-full-skin-screenshots.mjs # scripts/lib/theme-generator.mjs # scripts/validate.mjs # site/assets/app.js # tests/repository.test.mjs # tests/source-contract.test.mjs
…rmance' into Codex/audit-integration-20260727 # Conflicts: # README.md # README.zh-CN.md # apps/theme-manager/src-tauri/src/catalog.rs # apps/theme-manager/src/renderer/app.js # docs/CHANGELOG.md # docs/architecture.md # docs/desktop-manager.md # scripts/lib/theme-generator.mjs # scripts/prepare-desktop.mjs # scripts/validate.mjs # site/assets/app.js # tests/source-contract.test.mjs
…dering' into Codex/audit-integration-20260727 # Conflicts: # apps/theme-manager/src-tauri/src/catalog.rs # docs/CHANGELOG.md # docs/art-direction.md # packages/full-skin/runtime.css # screenshots/codex-beta-26.715.3651.0/manifest.json # scripts/lib/source-art-contract.mjs # scripts/validate.mjs # tests/repository.test.mjs # tests/source-contract.test.mjs # themes/catalog.json
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94e89f9896
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (forceRestartResolver) return Promise.resolve(false); | ||
| elements.forceRestartDialog.hidden = false; | ||
| elements.forceRestartConfirm.focus(); |
There was a problem hiding this comment.
When graceful shutdown times out on Windows and this overlay opens, it is only a <div role="dialog"> whose opener removes hidden; unlike the persistence dialog, it never makes the app shell inert, traps Tab, or remembers and restores the trigger. Keyboard users can therefore tab or press Ctrl+K into the underlying app while this destructive confirmation remains displayed, and closing it does not return focus to the initiating control. Reuse a native <dialog> or apply the same fallback focus/inert lifecycle here.
AGENTS.md reference: AGENTS.md:L14-L14
Useful? React with 👍 / 👎.
1 participant
Scope
This is the integration branch for the 2026-07-25 audit plan. It combines the remediation work from #15 through #25 and is ready for one review and CI pass as a release candidate.
Closes #4, #5, #6, #7, #8, #9, #10, #11, #12, #13, and #14.
What changed
Verification
npm run checknpm run a11y:checkinapps/theme-managerworkflow-lint.ps1Evidence limits
The recorded Beta capture is from Full Skin runtime v2. The site now labels it as reference evidence and says that v3 requires a new capture. The local
gallery:checkscript could not run because this host has nogoogle-chromeexecutable name, but the same Gallery path passed in an isolated browser session.