Skip to content

typo in led-fade example comments - #376

Merged
rwaldron merged 1 commit into
rwaldron:masterfrom
Resseguie:led-fade-typo
Jun 5, 2014
Merged

typo in led-fade example comments#376
rwaldron merged 1 commit into
rwaldron:masterfrom
Resseguie:led-fade-typo

Conversation

@Resseguie

Copy link
Copy Markdown
Collaborator

No description provided.

@rwaldron

rwaldron commented Jun 5, 2014

Copy link
Copy Markdown
Owner

I'm so sick of this example.

@rwaldron
rwaldron merged commit 76a5032 into rwaldron:master Jun 5, 2014
@Resseguie
Resseguie deleted the led-fade-typo branch June 5, 2014 23:26
@Resseguie

Copy link
Copy Markdown
Collaborator Author

Perhaps we should combine a bunch of these nearly identical examples into one that uses a little CLI like I did in the spark-io servo ones? Then we're not managing a bunch of small similar examples independently.

Or use a temporal queue like I did in another example?

@rwaldron

rwaldron commented Jun 6, 2014

Copy link
Copy Markdown
Owner

Go for it!

@Resseguie

Copy link
Copy Markdown
Collaborator Author

See if you like what I just did in the spark-io PR and if so, I'll translate it back to Johnny-Five.

rwaldron/particle-io#31

@Resseguie

Copy link
Copy Markdown
Collaborator Author

Related PR to combine the LED examples: #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants