Skip to content

Add PartialOrd and Ord implementations#52

Merged
pyfisch merged 1 commit into
rust-windowing:mainfrom
madsmtm:ord
Dec 4, 2024
Merged

Add PartialOrd and Ord implementations#52
pyfisch merged 1 commit into
rust-windowing:mainfrom
madsmtm:ord

Conversation

@madsmtm
Copy link
Copy Markdown
Member

@madsmtm madsmtm commented Dec 1, 2024

Allows using these types in BTreeMap/BTreeSet.

Note that we do not guarantee anything about the ordering between SemVer-compatible versions of the crate.

See also:

(And rust-windowing/winit#3866 for the case where PartialOrd/Ord wouldn't make sense).

Part of #19.

@pyfisch
Copy link
Copy Markdown
Contributor

pyfisch commented Dec 4, 2024

I don't in particular like Ord on types without a clear ordering but I think it is fine in this case to follow winit's lead.

@pyfisch pyfisch merged commit 7e75828 into rust-windowing:main Dec 4, 2024
@madsmtm madsmtm deleted the ord branch December 4, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants