Inherit package configuration (version and description) from workspace root#90
Conversation
MarijnS95
force-pushed
the
workspace-inheritance
branch
from
8caa471 to
4d44b86
Compare
It looks like this failed CI run (https://github.com/rust-mobile/xbuild/actions/runs/3631870305/jobs/6127317944) uses Ubuntu 22.04 where there's no On Arch I have an EDIT: It looks to be the clang/llvm 13 release that is still linking against and requiring |
|
Seems to be working on LLVM 14: https://github.com/MarijnS95/xbuild/actions/runs/3637588613 But @dvc94ch maybe we shouldn't use a EDIT: Reported at DioxusLabs/dioxus#600 (review) |
|
so this one is ready to rebase/merge? out of curiosity, do you know a good cross platform crate to get the platform specific config directory? looks like none of them work on android |
…space root Starting with [Rust 1.64] common `[package]` parameters (and dependencies) can now be specified in the workspace root manifest by setting `<field>.workspace=true` in a `[package]` and specifying its value in the workspace root manifest under [`[workspace.package]`]. Since `xbuild` reads the `version` and `description` field from `[package]` it has to support this new format and pull the values from the root manifest instead, in order to support projects utilizing this new format. This is currently implemented ad-hoc for the version and description field, but could be done in a cleaner way if/when more fields are needed. [Rust 1.64]: https://blog.rust-lang.org/2022/09/22/Rust-1.64.0.html#cargo-improvements-workspace-inheritance-and-multi-target-builds [`[workspace.package]`]: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-workspacepackage-table
MarijnS95
force-pushed
the
workspace-inheritance
branch
from
4d44b86 to
cd3b50a
Compare
|
Yes, thanks for fixing the CI!
What do you mean, a file path on the device? I don't think a "config" folder exists per-se, it's all a pretty generic |
|
fixed it here: xdg-rs/dirs#63 |
|
Oh you mean that (not really a config dir for android still, just a per-app consistent storage place like appdata and .config or .local). I've been using and maintaining https://crates.io/crates/app_dirs2 here. |
|
maybe a good candidate for the rust-mobile org? can we merge this PR? |
It also handles other platforms in a somewhat-generic way, don't think it fits but you'd have to ask the author otherwise.
Yes please! I was waiting for the CI to succeed and the new branch protection settings require at least one explicit approval (which I don't fancy bypassing). |
2 participants
Depends on #83
Starting with Rust 1.64 common
[package]parameters (and dependencies) can now be specified in the workspace root manifest by setting<field>.workspace=truein a[package]and specifying its value in the workspace root manifest under[workspace.package].Since
xbuildreads theversionanddescriptionfield from[package]it has to support this new format and pull the values from the root manifest instead, in order to support projects utilizing this new format.This is currently implemented ad-hoc for the version and description field, but could be done in a cleaner way if/when more fields are needed.